Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Person is typing..." message appear to be off-center in that bottom space #9086

Closed
mvtglobally opened this issue May 19, 2022 · 4 comments
Closed
Assignees

Comments

@mvtglobally
Copy link

mvtglobally commented May 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to app with account A
  2. From account B on another device/browser, start typing

Expected Result:

"Person is typing..." message should be centered in the bottom space and vertically aligned

Actual Result:

"Person is typing..." message appear to be off-center in that bottom space

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen Shot 2022-05-18 at 1 27 20 PM

Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1652905715417509

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2022

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Puneet-here
Copy link
Contributor

Proposal

We have to remove the styling on line 59

<TextWithEllipsis
leadingText={PersonalDetails.getDisplayName(this.state.usersTyping[0])}
trailingText={` ${this.props.translate('reportTypingIndicator.isTyping')}`}
textStyle={[styles.chatItemComposeSecondaryRowSubText]}
wrapperStyle={styles.chatItemComposeSecondaryRow}
leadingTextParentStyle={styles.chatItemComposeSecondaryRowOffset}
/>

@parasharrajat
Copy link
Member

Maybe a regression from #8691 cc: @luacmartins

@luacmartins
Copy link
Contributor

Yea, I think so. Here's the fix. Thanks for the ping @parasharrajat!

@melvin-bot melvin-bot bot closed this as completed May 19, 2022
@tgolen tgolen assigned tgolen and luacmartins and unassigned luacmartins and tgolen May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants