Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Workspace - Option missing for "Reimburse expenses" when user is offline #9178

Closed
kbecciv opened this issue May 26, 2022 · 5 comments
Closed
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented May 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the Expensify beta app
  2. Sign into a valid account
  3. Enable Airplane mode to mirror loss of internet
  4. Tap on the "Profile" icon > "Workspace" > "Reimburse expenses"
  5. Scroll under the "Track Distance section"

Expected Result:

The user expects to see a "Unlock next-day reimbursements" CTA with a "Connect bank account" button under the "Track" section. All other tabs within the workspace section when offline display a "Unlock" text prompt for unavailable options.

Actual Result:

There is nothing shown for the offline user under the track section within the ",Reimbursements" tab there is just a white space instead of "Unlock next-day reimbursements" CTA. Once the internet is returned, the correct CTA appears

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.67.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): emilio.utest@gmail.com/Emilio98

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5586060_No_connect_to_bank_account_cta_for_offline_user.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause -Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2022

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@iwiznia
Copy link
Contributor

iwiznia commented May 26, 2022

hmmmm this is because we load data from the server we don't yet have... since the offline support doc is not done yet, I think we should hold on this.
cc @Luke9389 @roryabraham @tgolen @marcaaron

@iwiznia iwiznia changed the title Workspace - Option missing for "Reimburse expenses" when user is offline [HOLD] Workspace - Option missing for "Reimburse expenses" when user is offline May 26, 2022
@iwiznia iwiznia added Improvement Item broken or needs improvement. Weekly KSv2 and removed Daily KSv2 labels May 26, 2022
@iwiznia iwiznia removed their assignment May 26, 2022
@marcaaron
Copy link
Contributor

+1 I think having these little "this doesn't work offline" issues is a bit distracting considering we are re-writing many flows and haven't trained anyone what to look for.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@tgolen
Copy link
Contributor

tgolen commented Aug 17, 2022

Yes, I am just going to close this.

@tgolen tgolen closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants