Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hold for payment 2022-12-06] [$4000] Web-IOU- After requesting money badge in the DM flashes with red 0.00 badge before changing to green badge with requested amount #9181

Closed
kavimuru opened this issue May 26, 2022 · 82 comments
Closed

[Hold for payment 2022-12-06] [$4000] Web-IOU- After requesting money badge in the DM flashes with red 0.00 badge before changing to green badge with requested amount #9181

kavimuru opened this issue May 26, 2022 · 82 comments
Assignees
@iwiznia @ntdiary @parasharrajat @dylanexpensify
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with any account
  3. Click on Fab menu - Request Money
  4. Put amount and click continue
  5. Select user and click continue

Expected Result:

Green badge with the amount requested appears in the DM

Actual Result:

The badge is switching from 0 (red) to requested amount (green) for a brief moment

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.67.0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com / Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5586705_Recording__491.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2022

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mvtglobally mvtglobally mentioned this issue May 26, 2022
Closed
13 tasks
@techievivek
Copy link
Contributor

Though this can be worked externally I am picking for myself to get comfortable with the codebase.

@melvin-bot melvin-bot bot added the Overdue label May 31, 2022
@techievivek
Copy link
Contributor

Will be looking at it today. Thanks

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2022
@techievivek
Copy link
Contributor

I did get to bottom of this but not sure why I am not able to reproduce this on my machine.
This is the part where we are calling the API to create the transaction.
And this is the part where we re-fetch the total IOU amount and update the ONYX.

Re-applying the engineering label so they can confirm if it is reproducible and very much noticable.

@techievivek techievivek added Engineering AutoAssignerTriage Auto assign issues for triage to an available triage team member and removed Engineering labels Jun 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2022

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 2, 2022
@bfitzexpensify
Copy link
Contributor

I'm having trouble reproducing this too. I think I got it once, but it was only because I was looking out for it quite intently. I'm not sure this is noticeable enough to be worthwhile to fix.

@techievivek
Copy link
Contributor

Closing this for now as per the above comments.

@techievivek techievivek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2022
@kbecciv
Copy link

kbecciv commented Sep 8, 2022

@techievivek @bfitzexpensify QA team is able to reproduce it with build 1.1.98.0

Recording.1807.mp4
Recording.1808.mp4

@kbecciv kbecciv reopened this Sep 8, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 8, 2022
@techievivek techievivek added Weekly KSv2 and removed Daily KSv2 labels Sep 9, 2022
@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2022
@techievivek
Copy link
Contributor

I think this can be worked externally so passing it to contributors.

@techievivek techievivek added the External Added to denote the issue can be worked on by a contributor label Sep 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2022

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 12, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Nov 21, 2022

Waiting on the PR. @ntdiary are you sending it?

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@iwiznia iwiznia removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2022
@ntdiary ntdiary mentioned this issue Nov 21, 2022
Merged
98 tasks
@ntdiary
Copy link
Contributor

ntdiary commented Nov 21, 2022

@iwiznia, oh, sorry, just sent it. I tested earlier today and the backend hasn't changed. 😂

@iwiznia
Copy link
Contributor

iwiznia commented Nov 21, 2022

heh yeah, it was deployed to our staging servers today and will be deployed to production some time tomorrow.

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Nov 24, 2022

PR is merged

@melvin-bot melvin-bot bot removed the Overdue label Nov 24, 2022
@iwiznia iwiznia added Weekly KSv2 and removed Daily KSv2 labels Nov 24, 2022
@trjExpensify trjExpensify added the Reviewing Has a PR in review label Nov 30, 2022
@JmillsExpensify
Copy link

Woo! Way to help us clear this one out.

@dylanexpensify
Copy link
Contributor

@iwiznia are we good to get this paid out now? Or where are we in the countdown

@luacmartins luacmartins changed the title [$4000] Web-IOU- After requesting money badge in the DM flashes with red 0.00 badge before changing to green badge with requested amount [Hold for payment 2022-12-06] [$4000] Web-IOU- After requesting money badge in the DM flashes with red 0.00 badge before changing to green badge with requested amount Dec 6, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Dec 7, 2022

You tell me, it was deployed 13 days ago

@ntdiary
Copy link
Contributor

ntdiary commented Dec 7, 2022

Hi, we fixed the issue first, I haven't applied for the job yet. 😂
And this is my first PR since the bounty rules changed, so I'm not quite sure, how much I should apply for?

@dylanexpensify
Copy link
Contributor

@ntdiary the bounty should be for $4000!

@dylanexpensify
Copy link
Contributor

@ntdiary @parasharrajat new job post here

@melvin-bot
Copy link

melvin-bot bot commented Dec 7, 2022

📣 @ntdiary You have been assigned to this job by @dylanexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ntdiary
Copy link
Contributor

ntdiary commented Dec 7, 2022 •
edited
Loading

Oh, @dylanexpensify, thanks! Because this PR needed to wait for the backend to deploy before it can be tested, and it was merged within two days after that, that's why I wasn't too sure the bounty. 😄

@ntdiary
Copy link
Contributor

ntdiary commented Dec 7, 2022

I will apply for it later. 😄

@ntdiary
Copy link
Contributor

ntdiary commented Dec 7, 2022

@dylanexpensify I've applied. 🙂

@dylanexpensify
Copy link
Contributor

offer sent!

@dylanexpensify
Copy link
Contributor

Ah @ntdiary reviewing your comment, you are right irt getting the bonus! I'll make sure when I pay you out to include it! ❤️

@dylanexpensify
Copy link
Contributor

@ntdiary payment (w/bonus!) sent!
@parasharrajat sent offer!

@dylanexpensify
Copy link
Contributor

payment sent @parasharrajat!

@dylanexpensify
Copy link
Contributor

job closed, contracts ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwiznia iwiznia

@ntdiary ntdiary

@parasharrajat parasharrajat

@dylanexpensify dylanexpensify

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests