Desktop deploy failing on notarization step

[luacmartins]

Problem

Coming from this thread, the Desktop deploy is failing on notarization step - see this workflow failure. This is most likely happening because we enabled 2FA for ios@expensify.com. Logs below:

Building Desktop App Archive Using Electron

  • electron-builder  version=22.13.1 os=20.6.0
  • loaded configuration  file=/Users/runner/work/App/App/config/electronBuilder.config.js
  • packaging       platform=darwin arch=x64 electron=17.0.0 appOutDir=desktop-build/mac
  • downloading     url=https://github.com/electron/electron/releases/download/v17.0.0/electron-v17.0.0-darwin-x64.zip size=81 MB parts=6
  • downloaded      url=https://github.com/electron/electron/releases/download/v17.0.0/electron-v17.0.0-darwin-x64.zip duration=1.[329](https://github.com/Expensify/App/runs/6695706323?check_suite_focus=true#step:8:330)s
  • signing         file=desktop-build/mac/New Expensify.app identityName=Developer ID Application: Expensify, Inc. (368M544MTT) identityHash=0633A09738B5C8B1FF97B81A951198CBB50B87A2 provisioningProfile=none
  ⨯ Failed to upload app to Apple's notarization servers

*** Error: Notarization failed for '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/electron-notarize-s22294/New Expensify.zip'.
*** Error: Unable to upload your app for notarization. Failed to get authorization for username '***' and password. (
    "Error Domain=NSCocoaErrorDomain Code=0 \"Status code: 0\" UserInfo={NSLocalizedDescription=Status code: 0, NSLocalizedFailureReason=The auth server returned a bad status code.}"
) (-1011)
 {
    NSLocalizedDescription = "Unable to upload your app for notarization.";
    NSLocalizedFailureReason = "Failed to get authorization for username '***' and password. (\n    \"Error Domain=NSCocoaErrorDomain Code=0 \\\"Status code: 0\\\" UserInfo={NSLocalizedDescription=Status code: 0, NSLocalizedFailureReason=The auth server returned a bad status code.}\"\n)";
}
  failedTask=build stackTrace=Error: Failed to upload app to Apple's notarization servers
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      *** Error: Notarization failed for '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/electron-notarize-s22294/New Expensify.zip'.
*** Error: Unable to upload your app for notarization. Failed to get authorization for username '***' and password. (
    "Error Domain=NSCocoaErrorDomain Code=0 \"Status code: 0\" UserInfo={NSLocalizedDescription=Status code: 0, NSLocalizedFailureReason=The auth server returned a bad status code.}"
) (-1011)
 {
    NSLocalizedDescription = "Unable to upload your app for notarization.";
    NSLocalizedFailureReason = "Failed to get authorization for username '***' and password. (\n    \"Error Domain=NSCocoaErrorDomain Code=0 \\\"Status code: 0\\\" UserInfo={NSLocalizedDescription=Status code: 0, NSLocalizedFailureReason=The auth server returned a bad status code.}\"\n)";
}
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          at /Users/runner/work/App/App/node_modules/electron-notarize/src/index.ts:87:13
    at Generator.next (<anonymous>)
    at fulfilled (/Users/runner/work/App/App/node_modules/electron-notarize/lib/index.js:4:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! new.expensify@1.1.70-2 desktop-build-staging: `scripts/build-desktop.sh staging "--publish" "always"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the new.expensify@1.1.70-2 desktop-build-staging script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/runner/.npm/_logs/2022-06-01T18_52_58_430Z-debug.log
Error: Process completed with exit code 1.

Why is this important

We can't deploy Desktop

Solution

🤷

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

Proposed fix:

1. Update to electron-notarize to at least version 1.1.0 to get the new XCode 13 notarize tool
2. Point the new notarize tool to our iOS fastlane JSON key

[luacmartins]

From this thread, it seems like we are on track to get this merged today 😄

[AndrewGable]

Ok I need help adjusting the APPLE_ID_PASSWORD secure variable. Asking internally.

[rafecolton]

Password updated

[AndrewGable]

Confirmed this is working now 👍

[luacmartins]

Thanks for fixing this @AndrewGable!