Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Preview of the image is not appearing for the first time when it's clicked to open #9333

Closed
kavimuru opened this issue Jun 7, 2022 · 2 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Jun 7, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch app and login with HT (High traffic)
  2. Go to any chat
  3. Sent attachment
  4. Open preview for attachment

Expected Result:

Preview should be open

Actual Result:

Preview is not appearing for the 1st time and on 2nd attempt it opens.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: v1.1.73-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+fish@applause.expensifail.com / Qwerty123
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5600110_Screen_Shot_2022-06-07_at_9 11 08_AM

Bug5600110_attachments.mp4

Image used to reproduce this issue
165643581-5673760a-0b67-4bd1-96c0-7c9f36a9d977

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2022

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@amyevans
Copy link
Contributor

amyevans commented Jun 8, 2022

I've tested this several times today on the latest staging version and cannot reproduce:

9333-attachment-testing.mov

I believe it was a regression caused by #8928, which was reverted in #9343, so it makes sense given the timing of my testing that I cannot reproduce. I also tested locally checked out to the commit for 1.1.73-0 (git co 284e0bada7851288be011e2898c91fa81234cc3e), and could reproduce, so that seems to line up as well.

Going to close the issue, but feel free to reopen if someone disagrees with this assessment or is able to in staging or production.

@amyevans amyevans closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants