-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace - Middle content is incorrect for the archived workspace chat #9365
Comments
Triggered auto assignment to @neil-marcellini ( |
By "middle text" do you mean the welcome message under the icon? What do you think it should say instead? See this comment, I believe this change is intentional. |
@neil-marcellini Based on the PR #8569 screenshots, there should be something about "Collaboration..." If the changes you are referring to were more recent, then maybe this is not an issue then. |
Ah those screenshots were with outdated data I think. But we do want to revert to the original welcome message like we're discussing here, so let's keep this issue to do that. @neil-marcellini you can make the PR for it if you're interested and I can review it. Or I can make it if you prefer. |
I would be happy to put up a PR to revert those changes. I'll put it up soon and request your review. |
Thank you, @neil-marcellini! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when execute PR: #8569
Action Performed:
Expected Result:
Middle text should start with "Collaboration between ..."for the archived workspace chat
Actual Result:
Middle content is incorrect for the archived workspace chat
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.74.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): expensifail accounts
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: