Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - ''Add pay method'' button flashes when tapped on it #9368

Closed
kbecciv opened this issue Jun 9, 2022 · 8 comments
Closed

Payments - ''Add pay method'' button flashes when tapped on it #9368

kbecciv opened this issue Jun 9, 2022 · 8 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Jun 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Tap on Avatar - Setting - Payments
  4. Tap ''Add pay method'' button

Expected Result:

''Add pay method'' button is not flash when tapped on it

Actual Result:

''Add pay method'' button flashes when tapped on it

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.74.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

ios.0806.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Luke9389
Copy link
Contributor

Luke9389 commented Jun 9, 2022

It's pretty hard to see exactly what's happening here. The transparent layer could be flashing out, or the button style could be turning dark green again.

Definitely seems like it can go External.

@Luke9389 Luke9389 added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Luke9389
Copy link
Contributor

Luke9389 commented Jun 9, 2022

Actually, @JmillsExpensify, do you think this issue is well-formed enough to export? We might want to clear up the expectations for the deliverables here before we start spending time on proposals.

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2022
@Luke9389
Copy link
Contributor

Getting @JmillsExpensify's take before moving forward with this.

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2022
@JmillsExpensify
Copy link

I think we should probably put this one hold. We're about to redo this entire page for N7. Another alternative is to close it for now given that we don't have a use case that supports the Wallet page in the production app.

@Luke9389
Copy link
Contributor

OK between those two I think closing is the better action to take. We'll perform tests and create follow up issues after the refactor, which will be made more simple if there isn't confusion between old and new problems.

@JmillsExpensify
Copy link

Awesome, yes this sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

3 participants