-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-09-23] [$500] 💥 Crash 💥 DetailsPage
#9545
Comments
Huh... This is 4 days overdue. Who can take care of this? |
This maaaay be the same as: #9182 |
Huh... This is 4 days overdue. Who can take care of this? |
Still overdue 6 days?! Let's take care of this! |
Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Triggered auto assignment to @stephanieelliott ( |
This |
Sounds like this is still happening even after #9182 was merged, so went ahead and posted this to Upwork: |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Hey @Santhosh-Sellavel @vladnobenladen can you both grab the job on Upwork when you get a chance? |
Applied @stephanieelliott! |
DetailsPage
DetailsPage
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.0-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-09-23. 🎊 |
Looks like this bug is related to this job: #10966 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Oop, holding on paying this out while we investigate the regression. In the meantime... @0xaim can you please grab the job on Upwork so we can pay you? |
Not overdue Melvin |
Sorry, which PR? That's an issue and I don't see any PR linked to it. |
My 2 cents... I'm guessing this PR: #10820 This comment sounds like it is on point on why this didn't work in this case: #10966 (comment) I feel like this isn't a regression because before the app just crashed and now we have an infinite spinner for that particular case.... which is a bit better. I don't know how we handle cases where the solution partially fixed the problem. |
@iwiznia, @stephanieelliott, @Santhosh-Sellavel, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too... |
Thanks for checking into it @aldo-expensify, if it didn't cause the regression I suppose we just pay it out as normal. @0xaim can you please grab the job on Upwork? We'll need you to do this in order to issue payment. https://www.upwork.com/jobs/~01d8e5aee09ed40c32 |
Just waiting for payment, not overdue! |
Still waiting on @0xmiroslav to grab the job on Upwork! https://www.upwork.com/jobs/~01d8e5aee09ed40c32 |
@Santhosh-Sellavel I've issued payment to you. @0xmiroslav please reopen this once you have accepted the job on Upwork and I will issue your payment 👍 |
@stephanieelliott applied for the job. thanks |
Non-fatal Exception: JavaScriptError
Cannot read property 'login' of undefined
main.jsbundle:240800:53 line 240800
DetailsPage
Number of Crashes: 10
Device Information
1.1.64.0
,1.1.66.1
,1.1.88.3
,1.1.95.4
,1.2.11-2
Stacktraces
Android 1.2.11-2
iOS 1.1.95.4
iOS 1.1.88.3
iOS 1.1.66.1
iOS 1.1.64.0
Internal Firebase Info
💥 DO NOT EDIT THIS SECTION 💥
Crash IDs:
de729788f9edff1f49f15d0662312d6c
,cf601647038c53d3414e31fc530bd13c
,e7a0562c55016455e23ac396f6209a6b
,e44f326d0fcda9d988d90cfc96d89dcc
,db69a57090ec5c0b33f7750c94527adb
Exception:
Cannot read property 'login' of undefined
The text was updated successfully, but these errors were encountered: