-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Refactor] Request a call page #9575
Comments
Holding on push to page discussion as per this comment |
On hold! |
On hold |
On hold |
On hold |
No longer on hold! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Oh sorry, I think the bot's comment shouldn't be here (maybe it's my fault), I just wanted to cite this issue. |
@ntdiary no worries! these comments have been all over the place. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Coming from the New Expensify Forms design doc, we should refactor RequestCallPage to use the new form component, follow the guidelines below:
Here's an example of a Form refactor: #9056
Guidelines
Testing
Verify that:
fix the errors
link focuses the first input with errorThe text was updated successfully, but these errors were encountered: