Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Crash 💥 .buildOptimisticReportAction #9945

Closed
melvin-bot bot opened this issue Jul 16, 2022 · 3 comments
Closed

💥 Crash 💥 .buildOptimisticReportAction #9945

melvin-bot bot opened this issue Jul 16, 2022 · 3 comments
Assignees
@marcaaron
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@melvin-bot
Copy link

melvin-bot bot commented Jul 16, 2022 •
edited
Loading

Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError

Cannot read property 'displayName' of null

address at index.android.bundle:1:1765639 .buildOptimisticReportAction

Number of Crashes: 25

Device Information

  • Platforms: Android, iOS
  • App Versions: 1.1.84-11, 1.1.89.0, 1.1.89-0, 1.1.89-4, 1.1.91-0, 1.1.91-1, 1.1.92-0, 1.2.11-2
  • Devices: samsung SM-G950F 9, Google Pixel 6a 12, samsung SM-S908E 12, samsung SM-G770F 12, samsung SM-M315F 12, Apple iPhone14,2 15.6.1, samsung SM-G991U1 12, samsung SM-G991U1 12

Stacktraces

Android 1.2.11-2 
.anonymous
._callTimer
.callTimers
.apply
.__callFunction
.anonymous
.__guard
.callFunctionReturnFlushedQueue
Android 1.1.92-0 
.anonymous
.map
.getAllParticipants
.ReportParticipantsPage
.renderWithHooks
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.callFunctionReturnFlushedQueue
Android 1.1.89-4 
.anonymous
.map
.getAllParticipants
.ReportParticipantsPage
.renderWithHooks
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.callFunctionReturnFlushedQueue
Android 1.1.91-1 
.anonymous
.map
.getAllParticipants
.ReportParticipantsPage
.renderWithHooks
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.callFunctionReturnFlushedQueue
Android 1.1.91-0 
.anonymous
.map
.getAllParticipants
.ReportParticipantsPage
.renderWithHooks
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.callFunctionReturnFlushedQueue
iOS 1.1.89.0 
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:263811:40:263811)
map (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:83203:34:83203)
getAllParticipants (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:263804:35:263804)
ReportParticipantsPage (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:263826:42:263826)
renderWithHooks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:6078:24:6078)
beginWork (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:9022:34:9022)
performUnitOfWork (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8682:27:8682)
workLoopSync (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8671:24:8671)
renderRootSync (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8653:21:8653)
performSyncWorkOnRoot (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8375:36:8375)
flushSyncCallbacks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:5170:32:5170)
scheduleUpdateOnFiber (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8145:530:8145)
enqueueSetState (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:5550:38:5550)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:1484:33:1484)
setWithOnyxState (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:95219:26:95219)
sendDataToConnection (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:81669:47:81669)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:81722:40:81722)
tryCallOne (/Users/distiller/react-native/sdks/hermes/build_iphoneos/lib/InternalBytecode/InternalBytecode.js:53:16:53)
anonymous (/Users/distiller/react-native/sdks/hermes/build_iphoneos/lib/InternalBytecode/InternalBytecode.js:139:27:139)
apply
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11500:26:11500)
_callTimer (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11412:17:11412)
_callReactNativeMicrotasksPass (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11439:17:11439)
callReactNativeMicrotasks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11643:44:11643)
__callReactNativeMicrotasks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3182:46:3182)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3057:45:3057)
__guard (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3165:15:3165)
flushedQueue (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3056:21:3056)
callFunctionReturnFlushedQueue (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3038:33:3038)
Android 1.1.89-0 
.anonymous
.map
.getAllParticipants
.ReportParticipantsPage
.renderWithHooks
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.callFunctionReturnFlushedQueue
Android 1.1.84-11 
.buildOptimisticReportAction
.addActions
.addAttachment
.onConfirm
.submitAndClose
.onPress
._performTransitionSideEffects
._receiveSignal
.onResponderRelease
.apply
.invokeGuardedCallbackImpl
.apply
.invokeGuardedCallback
.apply
.invokeGuardedCallbackAndCatchFirstError
.executeDispatch
.executeDispatchesAndReleaseTopLevel
.forEach
.forEachAccumulated
.anonymous
.batchedUpdatesImpl
.batchedUpdates
._receiveRootNodeIDEvent
.receiveTouches
.apply
.__callFunction
.anonymous
.__guard
.callFunctionReturnFlushedQueue
Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: de729788f9edff1f49f15d0662312d6c, ec744470ed376350d64982ce85383763, d988f25413cc626908a820c6bc3bfcaa, 4c93b18b258910fb1c5d82cd09bc318f, e366f3fd5314244f06b9a842cdc7e4d7, e0029f2d69e45a4c94319a8072aff69c, 1fa2c08a9a5c275b4e0aa05292d7f66b, 0ba5868fe87351596e73221f008eabb8
Exception: Cannot read property 'displayName' of null
@marcaaron marcaaron self-assigned this Jul 18, 2022
@marcaaron
Copy link
Contributor

Looks like this is happening because myPersonalDetails is null (or maybe undefined) when we set it here:

a6fbd64

My guess is that we are now dependent on currentUserEmail being initialized before personalDetails are read by Report.js in order to set the personal details so it doesn't happen.

Easy fix would be to just access the personalDetails object directly using the currentUserEmail so going to make that change.

@marcaaron
Copy link
Contributor

Oh wait, actually this code is not even on staging yet 😄

@marcaaron
Copy link
Contributor

Regardless, I think the changes I have will fix it since it uses lodash instead of trying to access a possibly null object property.

@marcaaron marcaaron mentioned this issue Jul 18, 2022
Merged
93 tasks
@marcaaron marcaaron added the Reviewing Has a PR in review label Jul 20, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcaaron marcaaron

Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcaaron