From b78b3e4bc09fc29423c34e2f41d360ce77e3bd5f Mon Sep 17 00:00:00 2001 From: advaitasol9 Date: Mon, 15 Aug 2022 10:50:52 +0530 Subject: [PATCH 1/2] removed sms domain issue 10198 --- src/libs/OptionsListUtils.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libs/OptionsListUtils.js b/src/libs/OptionsListUtils.js index d793bfaaef2d..6b71a9d3bbfa 100644 --- a/src/libs/OptionsListUtils.js +++ b/src/libs/OptionsListUtils.js @@ -104,9 +104,10 @@ function getPersonalDetailsForLogins(logins, personalDetails) { _.each(logins, (login) => { let personalDetail = personalDetails[login]; if (!personalDetail) { + const displayName = Str.removeSMSDomain(login); personalDetail = { login, - displayName: login, + displayName, avatar: ReportUtils.getDefaultAvatar(login), }; } From 957682dda8209e45e9e86fe107fc5b5d7ba85f78 Mon Sep 17 00:00:00 2001 From: advaitasol9 Date: Wed, 17 Aug 2022 11:00:49 +0530 Subject: [PATCH 2/2] github issue 10198 code changed as suggested --- src/libs/OptionsListUtils.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/OptionsListUtils.js b/src/libs/OptionsListUtils.js index 6b71a9d3bbfa..41a45e0b47d3 100644 --- a/src/libs/OptionsListUtils.js +++ b/src/libs/OptionsListUtils.js @@ -104,10 +104,9 @@ function getPersonalDetailsForLogins(logins, personalDetails) { _.each(logins, (login) => { let personalDetail = personalDetails[login]; if (!personalDetail) { - const displayName = Str.removeSMSDomain(login); personalDetail = { login, - displayName, + displayName: Str.removeSMSDomain(login), avatar: ReportUtils.getDefaultAvatar(login), }; }