[Fix] Add missing bottom margin style to Payment Page

[fedirjh]

Details

This is a regression from PR #14217 0479c58. Inside BasePaymentsPage.js , The listHeaderComponent is missing the margin bottom

Fixed Issues

$ #14743
$ #14743 (comment)

Tests

1. Navigate to Payments Page and check that payment Methods Title has it's bottom margin

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Imweb.Safari.mp4

Desktop

iOS

Android

[melvin-bot]

@luacmartins @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mollfpr]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

14746.mWeb.Chrome.mov

Mobile Web - Safari

14746.mWeb.Safari.mov

Desktop

iOS

14746.iOS.mov

Android

14746.Android.mov

[mollfpr]

All yours @luacmartins

[luacmartins]

LGTM!

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	604.664 ms → 624.619 ms (+19.955 ms, +3.3%)
App start TTI	674.680 ms → 687.004 ms (+12.325 ms, +1.8%)
App start nativeLaunch	19.871 ms → 20.194 ms (+0.323 ms, +1.6%)
App start regularAppStart	0.014 ms → 0.016 ms (+0.002 ms, +12.5%)
App start runJsBundle	181.625 ms → 179.586 ms (-2.039 ms, -1.1%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 604.664 ms Stdev: 19.254 ms (3.2%) Runs: 565.5236009999644 567.6768389999634 576.7711989999516 578.1180419998709 579.2950440000277 579.3652339999098 582.1398930000141 593.9431569998851 595.7025150000118 596.4515389999142 596.6601159999846 599.6353360000066 604.6949869999662 604.8229990000837 605.034262000001 606.7987480000593 607.324626000016 608.0345059999963 608.6753339999123 609.4363610000582 609.8918050000211 611.4369710000465 612.793171999976 620.0115569999907 621.5245769999456 622.3739420000929 623.9593100000639 626.0857339999638 626.2462979999837 634.4932869999902 635.9979659999954 638.3410650000442 Current Mean: 624.619 ms Stdev: 24.899 ms (4.0%) Runs: 576.7497160001658 589.0301919998601 591.816039999947 592.8518880000338 595.2141120000742 604.0603029998019 604.828980000224 607.1845299999695 608.968913000077 610.0251470000949 612.133790000109 613.2714440000709 613.4405520001892 614.6630049999803 620.6789549998939 621.1875 621.2032070001587 623.5982259998564 624.2814939999953 627.5157480000053 628.9544679999817 632.0462239999324 633.9916179999709 634.0271400001366 640.6160069999751 646.1291509999428 647.0450450000353 648.2589519999456 650.5554200001061 656.571290000109 660.7336019999348 663.5712490000296 697.2280279998668
App start TTI	Baseline Mean: 674.680 ms Stdev: 30.701 ms (4.6%) Runs: 596.0758579999674 631.3876320000272 642.4205020000227 644.9179559999611 646.8555039999774 646.9653069999767 648.8327209999552 649.2433690000325 652.2210050000576 653.4298199999612 655.9062540000305 659.2681309999898 661.9967130000005 664.2593239999842 666.8416539999889 667.7555960000027 669.4758859999711 674.1143529999536 680.7565800000448 683.6424050000496 687.4775320000481 689.4496519999811 692.9495520000346 698.1777980000479 698.9099080000306 711.2369000000181 713.6519359999802 715.1146769999759 718.2022430000361 718.7871009999653 719.123992000008 730.3097899999702 Current Mean: 687.004 ms Stdev: 37.327 ms (5.4%) Runs: 630.1369449999183 640.2098910000641 643.8612369999755 652.1372509999201 652.5313919999171 653.7894270000979 654.1555240000598 659.4219080000184 661.938744999934 662.9337730000261 668.3306849999353 670.0696549999993 670.3694809998851 677.1919869999401 678.5215429998934 682.0652260000352 683.1557720000856 683.804673000006 686.2140319999307 689.2217890000902 695.4831350001041 697.442289999919 698.8428650000133 701.8798140001018 713.8001500000246 720.6304659999441 727.0642170000356 732.3483219998889 739.7976029999554 774.5770439999178 795.2124890000559
App start nativeLaunch	Baseline Mean: 19.871 ms Stdev: 1.431 ms (7.2%) Runs: 18 18 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 20 21 21 21 21 21 21 21 21 22 22 22 23 Current Mean: 20.194 ms Stdev: 2.741 ms (13.6%) Runs: 17 17 17 18 18 18 18 18 18 18 18 19 19 19 19 19 20 20 20 21 21 21 21 22 22 22 22 24 26 27 27
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (6.8%) Runs: 0.01273600000422448 0.012938999920152128 0.013020999962463975 0.013020999962463975 0.01306200004182756 0.013143000076524913 0.013345999992452562 0.013671000022441149 0.013672000030055642 0.013834999990649521 0.01387499994598329 0.013956999988295138 0.014159999904222786 0.014160000020638108 0.014201000100001693 0.014364000060595572 0.014404000015929341 0.014444999978877604 0.014445000095292926 0.014484999934211373 0.014485000050626695 0.014649000018835068 0.014770000008866191 0.014810999971814454 0.014851999934762716 0.015218000044114888 0.015462999930605292 0.015502999885939062 0.015584999928250909 0.015868999995291233 0.016031999955885112 0.016805000021122396 Current Mean: 0.016 ms Stdev: 0.001 ms (6.0%) Runs: 0.014119999948889017 0.014404000015929341 0.014812000095844269 0.014933000085875392 0.015177000081166625 0.015381000004708767 0.015422000084072351 0.015544000081717968 0.01566500007174909 0.01566599984653294 0.015787999844178557 0.0157880000770092 0.015949999913573265 0.016032000072300434 0.016032000072300434 0.016275999834761024 0.016316999914124608 0.016357999993488193 0.016398000065237284 0.016478999983519316 0.01647999999113381 0.016519999830052257 0.01656000013463199 0.016600999981164932 0.016844999976456165 0.017253000056371093 0.01729299989528954 0.017699999967589974 0.01810700003989041 0.018148000119253993
App start runJsBundle	Baseline Mean: 181.625 ms Stdev: 16.933 ms (9.3%) Runs: 149 155 158 162 164 167 168 169 170 171 173 174 176 178 181 181 182 182 183 185 186 186 187 194 194 196 198 200 200 206 206 231 Current Mean: 179.586 ms Stdev: 14.550 ms (8.1%) Runs: 157 163 165 165 167 167 169 170 170 171 171 172 173 174 175 176 176 177 182 183 186 188 193 194 198 200 201 206 219

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.64-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.64-3 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅