show the main composer when a message in editing is deleted #17221

bernhardoj · 2023-04-10T16:21:57Z

Details

When we are editing a message in mobile screen, the main composer hide. When the message gets deleted from another client, the main composer keeps in hidden state, leaving the user unable to send any new message.

Fixed Issues

$ #16623
PROPOSAL: #16623 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Requires network connection to test.

QA Steps

Only for Android/iOS/mWeb

Login to the same account on 2 platforms (A & B)
Open the same chat on both platforms
Send 2 messages from any platform
Start edit for both message on the first platform (A)
Verify the main composer on platform (A) is hidden
Focus on the "first message you sent" edit composer
Delete the second message from platform (B)
Verify the main composer still hidden on platform (A)
Delete the first message from platform (B)
Verify the main composer shows on platform (A)

Desktop and web never hides the main composer, the videos are to make sure nothing is broken on those platforms.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-10.at.23.45.53.mov

Mobile Web - Chrome

Screen.Recording.2023-04-10.at.23.52.38.mov

Mobile Web - Safari

Screen.Recording.2023-04-10.at.23.55.37.mov

Desktop

Screen.Recording.2023-04-10.at.23.59.16.mov

iOS

Screen.Recording.2023-04-10.at.23.57.42.mov

Android

Screen.Recording.2023-04-10.at.23.48.51.mov

MelvinBot · 2023-04-10T16:22:05Z

@cristipaval @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr

Just need to add a comment to clarify the solution.

mollfpr · 2023-04-10T16:53:51Z

src/pages/home/report/ReportActionItemMessageEdit.js

+            return;
+        }
+
+        // Show the main composer when the focused message is deleted from another client


@bernhardoj Could you add an explanation of why we only do it in the focused message and what the problem we trying to solve with that code?

mollfpr · 2023-04-12T06:23:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

17221.Web.mov

Mobile Web - Chrome

17221.mWeb.Chrome.mov

Mobile Web - Safari

17221.mWeb.Safari.mp4

Desktop

17221.Desktop.mov

iOS

17221.iOS.mp4

Android

17221.Android.mp4

mollfpr

LGTM 👍

cc @cristipaval

OSBotify · 2023-04-12T13:52:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-13T03:43:51Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-17T22:58:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show the main composer when a message in editing is deleted

aefe58f

bernhardoj requested a review from a team as a code owner April 10, 2023 16:21

melvin-bot bot requested review from cristipaval and mollfpr and removed request for a team April 10, 2023 16:22

apply lint suggestion

28863af

mollfpr reviewed Apr 10, 2023

View reviewed changes

update comment

030437d

mollfpr approved these changes Apr 12, 2023

View reviewed changes

cristipaval approved these changes Apr 12, 2023

View reviewed changes

cristipaval merged commit b7afad3 into Expensify:main Apr 12, 2023

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

This was referenced Apr 14, 2023

Chat - Main composer is back on screen if swipe the keyboard down #17458

Closed

IOS - Chat - Main composer is displayed when editing second message #17531

Closed

MelvinBot mentioned this pull request Apr 17, 2023

[HOLD for payment 2023-04-24] [$1000] Users unable to text if an editing message is deleted #16623

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show the main composer when a message in editing is deleted #17221

show the main composer when a message in editing is deleted #17221

bernhardoj commented Apr 10, 2023

MelvinBot commented Apr 10, 2023

mollfpr left a comment

mollfpr Apr 10, 2023

bernhardoj Apr 10, 2023

mollfpr commented Apr 12, 2023 •

edited

Loading

mollfpr left a comment

OSBotify commented Apr 12, 2023

OSBotify commented Apr 13, 2023

OSBotify commented Apr 17, 2023

show the main composer when a message in editing is deleted #17221

show the main composer when a message in editing is deleted #17221

Conversation

bernhardoj commented Apr 10, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 10, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Apr 10, 2023

Choose a reason for hiding this comment

bernhardoj Apr 10, 2023

Choose a reason for hiding this comment

mollfpr commented Apr 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 12, 2023

OSBotify commented Apr 13, 2023

OSBotify commented Apr 17, 2023

mollfpr commented Apr 12, 2023 •

edited

Loading