From 04d4f892a9c34664cbd021410f603d9b7dedd40f Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Fri, 19 Mar 2021 11:34:57 -0700 Subject: [PATCH 1/3] Skip mobile staging deploys for production releases --- .github/workflows/android.yml | 1 + .github/workflows/ios.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index dfed77104a17..aebba077e93b 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -47,6 +47,7 @@ jobs: LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} - name: Run Fastlane beta + if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }} run: bundle exec fastlane android beta - name: Run Fastlane production diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index dee19d46c5e5..2f7c94cb0a85 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -63,6 +63,7 @@ jobs: LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} - name: Run Fastlane + if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }} run: bundle exec fastlane ios beta env: APPLE_CONTACT_EMAIL: ${{ secrets.APPLE_CONTACT_EMAIL }} From 113074285577093dc209dd17e0b5cca3e266874b Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Fri, 19 Mar 2021 11:39:38 -0700 Subject: [PATCH 2/3] Remove TODO and enable check for release event --- .github/workflows/android.yml | 4 +--- .github/workflows/ios.yml | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index aebba077e93b..66ec77d57ce7 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -13,9 +13,7 @@ jobs: if: github.actor == 'OSBotify' runs-on: ubuntu-latest env: -# TODO: Uncomment when we'd like to deploy to production -# SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }} - SHOULD_DEPLOY_PRODUCTION: ${{ false }} + SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }} steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index 2f7c94cb0a85..238aeaa38939 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -16,9 +16,7 @@ jobs: if: github.actor == 'OSBotify' runs-on: macos-latest env: -# TODO: Uncomment when we'd like to deploy to production7 -# SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }} - SHOULD_DEPLOY_PRODUCTION: ${{ false }} + SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }} steps: - uses: actions/checkout@v2 From c865c83f9d7b58c16255aaf85877fc603541abbf Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Fri, 19 Mar 2021 11:42:52 -0700 Subject: [PATCH 3/3] Skip prod deploys always for now --- .github/workflows/android.yml | 4 +++- .github/workflows/ios.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index 66ec77d57ce7..2785310c5574 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -48,8 +48,10 @@ jobs: if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }} run: bundle exec fastlane android beta + # TODO: uncomment when we want to release iOS to production - name: Run Fastlane production - if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }} +# if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }} + if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }} run: bundle exec fastlane android production env: VERSION: ${{ env.VERSION }} diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index 238aeaa38939..627e0bec28bd 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -69,8 +69,10 @@ jobs: APPLE_DEMO_EMAIL: ${{ secrets.APPLE_DEMO_EMAIL }} APPLE_DEMO_PASSWORD: ${{ secrets.APPLE_DEMO_PASSWORD }} + # TODO: uncomment when we want to release iOS to production - name: Run Fastlane for App Store release - if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }} +# if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }} + if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }} run: bundle exec fastlane ios production env: VERSION: ${{ env.NEW_IOS_VERSION }}