-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU - RBR is present in LHN with transaction thread #40460
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@abdulrahuman5196 PR ready. Can you please review the PR? 🙂 |
Hi, Sorry for delay. Will work on review. |
Any update here, @abdulrahuman5196? |
Working now. Will close out today or reassign if not. |
Thank you. |
Checking now |
6cb32e9
to
d299b32
Compare
@abdulrahuman5196 I have resolved all the regressions as mentioned above. Please check the PR. |
Checking now |
Any update here, sir? @abdulrahuman5196 |
Any update here, @abdulrahuman5196 ? |
@kaushiktd The change is not working Screen.Recording.2024-05-13.at.7.52.57.PM.mov |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
checking now |
I tested in web and the changes are looking good. Working on all platform testing |
I have a doubt, isn't the error message supposed to come below the bill image? @madmax330 @alexpensify Screen.Recording.2024-05-28.at.4.50.02.PM.movcc: @kaushiktd |
@abdulrahuman5196 Errors are showing with the |
@kaushiktd but in this pr the error message is shown above the bill image content which would be wrong then? |
If we need to display error below the image, I need to modify In component everything is being shown as children component, and image can not be separated in it. @abdulrahuman5196 https://github.com/Expensify/App/blob/main/src/components/OfflineWithFeedback.tsx#L146 |
Ok anyways, I will let @madmax330 / @alexpensify respond to this #40460 (comment) to see if we need to change the order of showing the error. Or is the above fine. |
@abdulrahuman5196 I have been assigned another issue and I need to make PR for that issue as well but this is not merged yet so how can I create new PR without affecting this? I am not able to see fork option because this one is still in progress. |
Friendly bump on this @madmax330 @alexpensify |
@abdulrahuman5196 @kaushiktd the error should not be above the receipt, but if that was not introduced in this PR let's create a separate GH for it. Otherwise let's fix it |
@madmax330 I believe it should be addressed separately since that will be a different issue than this one. |
@kaushiktd was this already this way or did this PR introduce it? |
It was this way already. @madmax330 |
Ok then no need to hold this PR on it, we can make a separate issue for it 👍🏽 |
@kaushiktd Android chrome and iOS safari videos are not present in the author's checklist. And the videos are old and doesn't reflect the multiple changes made. Kindly re-add the videos. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-01.at.12.21.21.AM.mp4Android: mWeb ChromeScreen.Recording.2024-06-01.at.12.30.21.AM.mp4iOS: NativeScreen.Recording.2024-06-01.at.12.08.20.AM.mp4iOS: mWeb SafariScreen.Recording.2024-06-01.at.12.15.16.AM.mp4MacOS: Chrome / SafariScreen.Recording.2024-05-31.at.9.37.24.PM.mp4MacOS: DesktopScreen.Recording.2024-05-31.at.11.16.04.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @madmax330
🎀 👀 🎀
C+ Reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@abdulrahuman5196 @madmax330 can you please manually send me upwork invite? I have not received it yet. |
@kaushiktd no worries BZ member will take during the payment time. |
This PR is failing because of issue #39689 The issue is reproducible in: Web bandicam.2024-06-05.00-39-01-680.mp4 |
I've checked our PR code using the steps mentioned in the PR request. It is working properly as expected on both the development and staging servers. https://www.loom.com/share/d676aa1541744001af10cee0bb4aef1d?sid=893bf215-5647-4516-b5e4-6ac955352ffe |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
|
@abdulrahuman5196 @madmax330 Ammm, have not received any manual invitation on my Upwork yet. Can you help here please? |
I'll reply to your question in the original GH. |
Details
Fixed Issues
$ #39689
PROPOSAL:#39689 (comment)
Tests
I've tested the scenarios with MacOS / Chrome / Safari / Android / IOS
Steps to follow:
Open the Expensify application in your device and follow below steps:
Offline tests
QA Steps
Open the Expensify application in your device and follow below steps:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android-chrome.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4