From 1a2885bfba6610da9c0369d6d287af2e1b3c5f99 Mon Sep 17 00:00:00 2001 From: Srikar Parsi Date: Wed, 15 May 2024 19:15:01 -0400 Subject: [PATCH 1/3] Dont hide group chats --- src/libs/ReportUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index c71d39a47cd4..65a1e1f81e27 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -5181,7 +5181,7 @@ function shouldReportBeInOptionList({ } // Hide chats between two users that haven't been commented on from the LNH - if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && canHideReport) { + if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && !isGroupChat(report) && canHideReport) { return false; } From f15c4341cf9615f272cad73ac31259d7a1bfdab7 Mon Sep 17 00:00:00 2001 From: Srikar Parsi Date: Tue, 21 May 2024 02:10:10 -0400 Subject: [PATCH 2/3] optimistic --- src/libs/ReportUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index 65a1e1f81e27..f10e15c743fc 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -4373,7 +4373,7 @@ function buildOptimisticGroupChatReport(participantAccountIDs: number[], reportN undefined, undefined, undefined, - CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, + CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, undefined, undefined, undefined, From b8c8d5733237358799a50717d1de076e638842c9 Mon Sep 17 00:00:00 2001 From: Srikar Parsi <48188732+srikarparsi@users.noreply.github.com> Date: Tue, 21 May 2024 16:00:56 -0400 Subject: [PATCH 3/3] use undefined since default is ALWAYS Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com> --- src/libs/ReportUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index f10e15c743fc..d4a609a30a7d 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -4373,7 +4373,7 @@ function buildOptimisticGroupChatReport(participantAccountIDs: number[], reportN undefined, undefined, undefined, - CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, + undefined, undefined, undefined, undefined,