From 907afc435e94efd6a80f8c25f22cf6f2da1dd478 Mon Sep 17 00:00:00 2001 From: rory Date: Thu, 26 Sep 2024 15:35:17 -0700 Subject: [PATCH 1/2] Fix types --- src/languages/en.ts | 3 ++- src/languages/es.ts | 3 ++- src/languages/params.ts | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index dabb592b2bf..6a90b1f8302 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -54,6 +54,7 @@ import type { DefaultVendorDescriptionParams, DelegateRoleParams, DelegateSubmitParams, + DelegatorParams, DeleteActionParams, DeleteConfirmationParams, DeleteExpenseTranslationParams, @@ -4818,7 +4819,7 @@ const translations = { } }, genericError: 'Oops, something went wrong. Please try again.', - onBehalfOfMessage: (delegator: string) => `on behalf of ${delegator}`, + onBehalfOfMessage: ({delegator}: DelegatorParams) => `on behalf of ${delegator}`, accessLevel: 'Access level', confirmCopilot: 'Confirm your copilot below.', accessLevelDescription: 'Choose an access level below. Both Full and Limited access allow copilots to view all conversations and expenses.', diff --git a/src/languages/es.ts b/src/languages/es.ts index 3dc528fe825..8d8b33ca57d 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -53,6 +53,7 @@ import type { DefaultVendorDescriptionParams, DelegateRoleParams, DelegateSubmitParams, + DelegatorParams, DeleteActionParams, DeleteConfirmationParams, DeleteExpenseTranslationParams, @@ -5338,7 +5339,7 @@ const translations = { } }, genericError: '¡Ups! Ha ocurrido un error. Por favor, inténtalo de nuevo.', - onBehalfOfMessage: (delegator: string) => `en nombre de ${delegator}`, + onBehalfOfMessage: ({delegator}: DelegatorParams) => `en nombre de ${delegator}`, accessLevel: 'Nivel de acceso', confirmCopilot: 'Confirma tu copiloto a continuación.', accessLevelDescription: 'Elige un nivel de acceso a continuación. Tanto el acceso Completo como el Limitado permiten a los copilotos ver todas las conversaciones y gastos.', diff --git a/src/languages/params.ts b/src/languages/params.ts index 20e7ac34185..8ed12228306 100644 --- a/src/languages/params.ts +++ b/src/languages/params.ts @@ -469,6 +469,8 @@ type ReconciliationWorksParams = {lastFourPAN: string}; type DelegateRoleParams = {role: DelegateRole}; +type DelegatorParams = {delegator: string}; + type RoleNamesParams = {role: string}; type AssignCardParams = { @@ -565,6 +567,7 @@ export type { AssignedYouCardParams, SpreadCategoriesParams, DelegateRoleParams, + DelegatorParams, ReconciliationWorksParams, LastSyncAccountingParams, SyncStageNameConnectionsParams, From a5ff556d655d835f0cf82405928ed943b9a0bd55 Mon Sep 17 00:00:00 2001 From: rory Date: Thu, 26 Sep 2024 16:03:56 -0700 Subject: [PATCH 2/2] Fix onBehalfOfMessage usage --- src/pages/home/report/ReportActionItemSingle.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/home/report/ReportActionItemSingle.tsx b/src/pages/home/report/ReportActionItemSingle.tsx index 01a0847b4f7..56eaf814ff1 100644 --- a/src/pages/home/report/ReportActionItemSingle.tsx +++ b/src/pages/home/report/ReportActionItemSingle.tsx @@ -375,7 +375,7 @@ function ReportActionItemSingle({ ) : null} {action?.delegateAccountID && !isReportPreviewAction && ( - {translate('delegate.onBehalfOfMessage', accountOwnerDetails?.displayName ?? '')} + {translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})} )} {children}