From 8356ac9100ff1e25962fd21206653aa6f035ae20 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 17 Mar 2022 12:43:23 -0600 Subject: [PATCH 1/4] fix deploy announce in slack --- .github/workflows/platformDeploy.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index 4cd4e5ba56d5..ca4a31bacd92 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -374,9 +374,11 @@ jobs: postSlackMessageOnSuccess: name: Post a Slack message when all platforms deploy successfully runs-on: ubuntu-latest - if: ${{ success() }} needs: [android, desktop, iOS, web] steps: + - name: Set version + run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV" + - name: 'Announces the deploy in the #announce Slack room' uses: 8398a7/action-slack@v3 with: From cc00ae63fe1a61258411c532e5239e38af88be06 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 17 Mar 2022 13:31:07 -0600 Subject: [PATCH 2/4] add actions/checkout --- .github/workflows/platformDeploy.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index ca4a31bacd92..f90f94e34b17 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -376,6 +376,10 @@ jobs: runs-on: ubuntu-latest needs: [android, desktop, iOS, web] steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 0 + - name: Set version run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV" From 66f0ef871995944e317b1dcabba9ada298ad720b Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 17 Mar 2022 13:32:10 -0600 Subject: [PATCH 3/4] remove fetch-depth --- .github/workflows/platformDeploy.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index f90f94e34b17..c8651d428d4b 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -377,8 +377,6 @@ jobs: needs: [android, desktop, iOS, web] steps: - uses: actions/checkout@v2 - with: - fetch-depth: 0 - name: Set version run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV" From 7aeb4d57dd4686a1416693e6b0fdff892e87a3d6 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Thu, 17 Mar 2022 14:13:53 -0600 Subject: [PATCH 4/4] add if conditional --- .github/workflows/platformDeploy.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index c8651d428d4b..c0c9fe98676d 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -374,6 +374,7 @@ jobs: postSlackMessageOnSuccess: name: Post a Slack message when all platforms deploy successfully runs-on: ubuntu-latest + if: ${{ success() }} needs: [android, desktop, iOS, web] steps: - uses: actions/checkout@v2