fix: timezone shown for our own email #9642

Puneet-here · 2022-06-30T17:33:57Z

Details

Fixed timezone showing up for our own email at rooms when there is no user except you

Fixed Issues

$ #9238

Tests

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should not contain any other member except you)
Check that you aren't seeing timezone above the composer

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should only contain one other member except you)
Check that you see the timezone of that other user

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should contain 2 users excluding you)
Check that you aren't seeing timezone

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should not contain any other member except you)
Check that you aren't seeing timezone above the composer

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should only contain one other member except you)
Check that you see the timezone of that other user

Click on fab icon > new workspace (if you don't have any workspace)
Search #announce room and open it (note: the room should contain 2 users excluding you)
Check that you aren't seeing timezone

Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-06-30.at.10.38.54.PM.mov

Screen.Recording.2022-06-30.at.10.40.45.PM.mov

Screen.Recording.2022-06-30.at.10.40.17.PM.mov

Mobile Web

Screen.Recording.2022-06-30.at.10.43.29.PM.mov

Desktop

Screen.Recording.2022-06-30.at.10.59.21.PM.mov

iOS

Screen.Recording.2022-06-30.at.10.47.52.PM.mov

Android

Screen.Recording.2022-06-30.at.10.56.30.PM.mov

src/libs/ReportUtils.js

mananjadhav

@Puneet-here I've posted the comment and also suggestion of the function.

I would also request:

Mark every item in the checklist. If it applies then test and mark, if it doesn't apply then just mark so that we know we've gone through it and adhere to it.
QA Steps says go to #announce-room, can we post atleast in one of the steps how to create an Announce with participants?

Puneet-here · 2022-07-13T08:57:56Z

For some reason the commit to merge main branch wasn't signed so I had to reset it and force push.

thienlnam

This is getting there! Just a few more comments

src/libs/ReportUtils.js

src/pages/home/report/ReportActionCompose.js

thienlnam

Can we also see a video for:

Chat with concierge (No timezone should be shown)
Chat with 1:1 (Timezone should be shown)
Chat with another user and concierge ( Timezone should be shown)

src/libs/ReportUtils.js

src/pages/home/report/ReportActionCompose.js

Puneet-here · 2022-07-15T18:16:49Z

Removed the function.

And here's the video -

Screen.Recording.2022-07-15.at.11.05.35.PM.mov

mananjadhav · 2022-07-15T22:37:52Z

@Puneet-here Did we make the null handling change? I can't find it.

Puneet-here · 2022-07-16T05:09:54Z

@mananjadhav, no I didn't. As It's not needed.

Same as above, this might be fine since participantsWithoutExpensifyEmails will be an empty array

thienlnam · 2022-07-18T17:30:38Z

Sweet, @mananjadhav please go ahead and complete testing for this PR

mananjadhav · 2022-07-18T20:03:40Z

@thienlnam Tests well and changes look good.

🎀 👀 🎀
C+ reviewed

Quick comment: The timezone text is aligned a bit on the right. It is right aligned in the main chat as well and doesn't need to be changed here, but I thought I'll just highlight it here.

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

thienlnam · 2022-07-18T21:35:18Z

Quick comment: The timezone text is aligned a bit on the right. It is right aligned in the main chat as well and doesn't need to be changed here, but I thought I'll just highlight it here.

This doesn't seem related to any changes made here, should be happening on prod as well so feel free to report in the #expensify-open-source channel for us to create a new issue

OSBotify · 2022-07-18T21:41:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mananjadhav · 2022-07-18T21:59:40Z

@Puneet-here I just took the latest main branch pull and it seems this change is crashing the App on a fresh login.

cc - @thienlnam

mananjadhav · 2022-07-18T22:16:19Z

@thienlnam IMP: Please check this PR for the login crash on this report - #9966

I still couldn't understand why it worked fine beforehand (especially with the typo in the prop name) and now its crashing.

chiragsalian · 2022-07-18T22:37:32Z

Yup i am seeing the same issue and dev is broken for me. Was going to push the same fix but you got to it sooner. Checking your code.

OSBotify · 2022-07-25T17:21:14Z

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Puneet-here requested a review from a team as a code owner June 30, 2022 17:33

melvin-bot bot requested review from mananjadhav and thienlnam and removed request for a team June 30, 2022 17:34

thienlnam requested changes Jun 30, 2022

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

mananjadhav suggested changes Jul 12, 2022

View reviewed changes

filter out expensify emails

454ff18

thienlnam requested changes Jul 13, 2022

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Show resolved Hide resolved

src/pages/home/report/ReportActionCompose.js Show resolved Hide resolved

thienlnam requested changes Jul 14, 2022

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Show resolved Hide resolved

src/pages/home/report/ReportActionCompose.js Show resolved Hide resolved

remove function

801dbbe

thienlnam approved these changes Jul 18, 2022

View reviewed changes

thienlnam merged commit 2e0eca5 into Expensify:main Jul 18, 2022

mananjadhav mentioned this pull request Jul 18, 2022

fix: typo in personaldetails prop #9966

Merged

93 tasks

OSBotify mentioned this pull request Jul 18, 2022

Deploy Checklist: New Expensify 2022-07-18 #9970

Closed

79 tasks

Puneet-here mentioned this pull request Jul 19, 2022

Use currentUserPersonalDetails key #9987

Merged

92 tasks

kbecciv mentioned this pull request Jul 20, 2022

Room - Details - Time zone is not displayed in member list of room. #10018

Closed

melvin-bot bot mentioned this pull request Jul 25, 2022

[HOLD for payment 2022-08-08] [HOLD for payment 2022-08-01] [$500] At #admins and #announce rooms, users own timezone displayed - reported by @Puneet-here #9238

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: timezone shown for our own email #9642

fix: timezone shown for our own email #9642

Puneet-here commented Jun 30, 2022 •

edited

Loading

mananjadhav left a comment

Puneet-here commented Jul 13, 2022

thienlnam left a comment

thienlnam left a comment

Puneet-here commented Jul 15, 2022

mananjadhav commented Jul 15, 2022

Puneet-here commented Jul 16, 2022

thienlnam commented Jul 18, 2022

mananjadhav commented Jul 18, 2022

PR Reviewer Checklist

thienlnam commented Jul 18, 2022

OSBotify commented Jul 18, 2022

mananjadhav commented Jul 18, 2022

mananjadhav commented Jul 18, 2022 •

edited

Loading

chiragsalian commented Jul 18, 2022

OSBotify commented Jul 25, 2022

fix: timezone shown for our own email #9642

fix: timezone shown for our own email #9642

Conversation

Puneet-here commented Jun 30, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav left a comment

Choose a reason for hiding this comment

Puneet-here commented Jul 13, 2022

thienlnam left a comment

Choose a reason for hiding this comment

thienlnam left a comment

Choose a reason for hiding this comment

Puneet-here commented Jul 15, 2022

mananjadhav commented Jul 15, 2022

Puneet-here commented Jul 16, 2022

thienlnam commented Jul 18, 2022

mananjadhav commented Jul 18, 2022

PR Reviewer Checklist

thienlnam commented Jul 18, 2022

OSBotify commented Jul 18, 2022

mananjadhav commented Jul 18, 2022

mananjadhav commented Jul 18, 2022 • edited Loading

chiragsalian commented Jul 18, 2022

OSBotify commented Jul 25, 2022

Puneet-here commented Jun 30, 2022 •

edited

Loading

mananjadhav commented Jul 18, 2022 •

edited

Loading