Skip to content

Commit

Permalink
Upgrade react-native-screens version and remove detachInactiveScreens…
Browse files Browse the repository at this point in the history
… prop
  • Loading branch information
tugbadogan committed Jun 3, 2021
1 parent 37b3591 commit c0766f5
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 31 deletions.
57 changes: 32 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
"@react-native-masked-view/masked-view": "^0.2.4",
"@react-native-picker/picker": "^1.9.11",
"@react-navigation/compat": "^5.3.15",
"@react-navigation/drawer": "^6.0.0-next.10",
"@react-navigation/native": "^6.0.0-next.8",
"@react-navigation/stack": "^6.0.0-next.17",
"@react-navigation/drawer": "^6.0.0-next.17",
"@react-navigation/native": "^6.0.0-next.13",
"@react-navigation/stack": "^6.0.0-next.25",
"babel-plugin-transform-remove-console": "^6.9.4",
"dotenv": "^8.2.0",
"electron-context-menu": "^2.3.0",
Expand Down Expand Up @@ -84,11 +84,11 @@
"react-native-pdf": "^6.2.2",
"react-native-permissions": "^3.0.1",
"react-native-picker-select": "8.0.4",
"react-native-reanimated": "^2.1.0",
"react-native-plaid-link-sdk": "^7.0.5",
"react-native-reanimated": "^2.1.0",
"react-native-render-html": "^6.0.0-alpha.10",
"react-native-safe-area-context": "^3.1.4",
"react-native-screens": "2.17.1",
"react-native-screens": "^3.0.0",
"react-native-svg": "^12.1.0",
"react-native-web": "^0.14.1",
"react-pdf": "^5.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/libs/Navigation/AppNavigator/AuthScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ class AuthScreens extends React.Component {
animationEnabled: true,
gestureDirection: 'horizontal',
cardOverlayEnabled: true,
presentation: 'transparentModal',

// This is a custom prop we are passing to custom navigator so that we will know to add a Pressable overlay
// when displaying a modal. This allows us to dismiss by clicking outside on web / large screens.
Expand All @@ -180,7 +181,6 @@ class AuthScreens extends React.Component {
// a header will briefly open and close the keyboard and crash Android.
// eslint-disable-next-line react/jsx-props-no-multi-spaces
keyboardHandlingEnabled={false}
detachInactiveScreens={false}
>
{/* The MainDrawerNavigator contains the SidebarScreen and ReportScreen */}
<RootStack.Screen
Expand Down

0 comments on commit c0766f5

Please sign in to comment.