[No QA] Skip IOU participants step if launched from within chat

[Maftalion]

Details

• Skip the IOUParticipants if routed from a chat
• Dependent on Configure Confirm step for IOU #2120 being merged

Fixed Issues

Fixes #2246

Tests

• Add the following imports in src/pages/home/report/ReportActionCompose.js:

import Navigation from '../../../libs/Navigation/Navigation';
import ROUTES from '../../../ROUTES';

• Add the following to the menuItems in src/pages/home/report/ReportActionCompose.js:

{
    icon: Paperclip,
    text: 'Request Money',
    onSelected: () => {
        Navigation.navigate(
            ROUTES.getIouRequestRoute(this.props.reportID),
        );
    },
},
{
    icon: Paperclip,
    text: 'Split Bill',
    onSelected: () => {
        Navigation.navigate(
            ROUTES.getIouSplitRoute(this.props.reportID),
        );
    },
},

• Replace IOU_REQUEST and IOU_BILL with the following in src/ROUTES.js:

    IOU_REQUEST: 'iou/request/:reportID',
    getIouRequestRoute: reportID => `iou/request/${reportID}`,
    IOU_BILL: 'iou/split/:reportID',
    getIouSplitRoute: reportID => `iou/split/${reportID}`,

• Go into any chat, click the "+" icon and click one of the above menu items
• Go through the IOU steps and confirm IOUParticipants step was skipped
• Then remove this.props.reportID from the navigation request above and go through the flow again, this time confirming that the IOUParticipants step does appear.

QA Steps

Same as above.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Screen.Recording.2021-04-20.at.1.01.57.AM.mov

Mobile Web

Screen.Recording.2021-04-20.at.1.01.08.AM.mov

Desktop

Screen.Recording.2021-04-20.at.1.04.32.AM.mov

iOS

Screen.Recording.2021-04-20.at.12.54.35.AM.mov

Android

Screen.Recording.2021-04-20.at.1.16.12.AM.mov

[thienlnam]

Changes look good! I also went ahead and added the imports to the description

[trjExpensify]

👋 Just a heads up that IOUConfirm #2120 has recently merged 👍

[thienlnam]

There should now be an avatarThumbnail on personalDetails which is an 80x80 version of the image, can we double check to make sure we're using those instead of full sized? You might also need to update getPersonalDetailsForLogins

[Julesssss]

Good spot @thienlnam.

I could be wrong, but I think that might be out of scope for this issue as participant Avatars were implemented in a previous issue. If we spot that the incorrect size is used though, I'll be happy to create a new issue for this.

[thienlnam]

That's fair, let's go ahead with that then if the incorrect sizes are showing up

[Julesssss]

Noticed a couple of small things

[Julesssss]

Ah, actually could you keep the new dynamic routes, please. We'll use both the old static and new dynamic roites.

[OSBotify]

🚀 Deployed to staging 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@Julesssss / @thienlnam This one doesn't look QAable by us. Can you let me know if this is internal QA or if there are QA steps that can be executed by Applause? Thanks in advance

[thienlnam]

Hey @isagoico, our bad - looks like the routes for these options to be shown aren't actually enabled yet so this is not something that can be tested yet

[OSBotify]

🚀 Deployed to production in version: 1.0.39-5🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅