Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add better logging for StagingDeployCash #3642

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Unfortunately #3173 did not work, and I'm not sure why. This just adds better logs to help debug the issue. Once the issue has been properly diagnosed, I should be able to update the unit tests to cover the fix.

Fixed Issues

Follow-up for #3173

Tests / QA Steps

None.

Tested On

n/a – GitHub only.

@roryabraham roryabraham self-assigned this Jun 17, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 17, 2021 17:31
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team June 17, 2021 17:31
@AndrewGable
Copy link
Contributor

Merging to test!

@AndrewGable AndrewGable merged commit a3b2757 into main Jun 17, 2021
@AndrewGable AndrewGable deleted the Rory-BetterLogsForStagingDeployCash branch June 17, 2021 17:40
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.70-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants