We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coming from Expensify/App#25481 (comment)
Generally, to delete stuff from Onyx you set it to null. However:
However, the subscriber is getting the new collection with a null value for the item that was meant to be deleted.
TBD. According to a contributor:
it is due to notify the subscribers with the changed values before updating the storage. react-native-onyx/lib/Onyx.js Lines 508 to 515 in 79bfb5e // Subscriber is a regular call to connect() and provided a callback if (_.isFunction(subscriber.callback)) { if (isCollectionKey(subscriber.key) && subscriber.waitForCollectionCallback) { const cachedCollection = getCachedCollection(subscriber.key); cachedCollection[key] = data; subscriber.callback(cachedCollection); continue; }
it is due to notify the subscribers with the changed values before updating the storage.
react-native-onyx/lib/Onyx.js
Lines 508 to 515 in 79bfb5e
The text was updated successfully, but these errors were encountered:
Created a quick fix: #311
Sorry, something went wrong.
roryabraham
Successfully merging a pull request may close this issue.
Coming from Expensify/App#25481 (comment)
Problem
Generally, to delete stuff from Onyx you set it to null. However:
However, the subscriber is getting the new collection with a null value for the item that was meant to be deleted.
Solution
TBD. According to a contributor:
The text was updated successfully, but these errors were encountered: