Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null values from cache to improve Onyx read speed #553

Closed
chrispader opened this issue May 24, 2024 · 3 comments
Closed

Remove null values from cache to improve Onyx read speed #553

chrispader opened this issue May 24, 2024 · 3 comments
Assignees

Comments

@chrispader
Copy link
Contributor

In #411 we changed code in Onyx to persist null values in cache, in order for the user to know, that a value has been accessed before but there's no value.

This fixed an issue here but apperantly isn't the perfect solution, since it requires us to remove null values on read, as implemented in #519.

This PR removes null values from cache and removes calls to removeNestedNullValues on read. Instead, null values are only going to be removed on write (e.g. Onyx.merge/Onyx.set).

This should speed up read speeds by a lot, since it prevents the problem described in https://expensify.slack.com/archives/C05LX9D6E07/p1716395008375049?thread_ts=1716303470.244179&cid=C05LX9D6E07

@kevinksullivan
Copy link

asked for status update on this here

https://expensify.slack.com/archives/C05LX9D6E07/p1717540938581599

@mountiny mountiny moved this from CRITICAL to LOW in [#whatsnext] #quality Jun 4, 2024
@chrispader
Copy link
Contributor Author

As described by @mountiny in https://expensify.slack.com/archives/C05LX9D6E07/p1717542026961829?thread_ts=1717540938.581599&cid=C05LX9D6E07, working on shipping this in the current Onyx bump PR

@muttmuure
Copy link

This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants