Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wifi update fixes #32

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Conversation

pkendall64
Copy link
Contributor

@pkendall64 pkendall64 commented Nov 7, 2021

Problem 1

Uploading long named files caused "File not found" errors. This is because SPIFFS only allows 31 char filenames.

Solution 1

Ignore the name passed in on upload for the name on the SPIFFS partition and use a hard-coded name.

Problem 2

Uploading STM firmware via the backpack in AP mode would finish with "Update Failed" and no other information, implying that the network had gone away, i.e. the ESP was rebooted.

Solution 2

Why reboot the ESP when completing the STM update? Don't do that.

Test Plan

Windows STA Mode

Action Expectation Status
Update "backpack" from RX to TXBP Should show upload progress, then popup mismatch dialog
Click "Cancel" should abort
Click "Flash anyway" should show flashing progress, display "Success" dialog and update to TXBP firmware
Update "backpack" from TXBP to TXBP Should show upload and flashing progress, then display "Success" dialog
Update "TX" firmware using .elrs file Should show upload and flashing progress, then display "Success" dialog

Windows AP Mode

Action Expectation Status
Update "backpack" from RX to TXBP Should show upload progress, then popup mismatch dialog
Click "Cancel" should abort
Click "Flash anyway" should show flashing progress, display "Success" dialog and update to TXBP firmware
Update "backpack" from TXBP to TXBP Should show upload and flashing progress, then display "Success" dialog
Update "TX" firmware using .elrs file Should show upload and flashing progress, then display "Success" dialog

Mac STA Mode

Action Expectation Status
Update "backpack" from RX to TXBP Should show upload progress, then popup mismatch dialog
Click "Cancel" should abort
Click "Flash anyway" should show flashing progress, display "Success" dialog and update to TXBP firmware
Update "backpack" from TXBP to TXBP Should show upload and flashing progress, then display "Success" dialog
Update "TX" firmware using .elrs file Should show upload and flashing progress, then display "Success" dialog

Mac AP Mode

Action Expectation Status
Update "backpack" from RX to TXBP Should show upload progress, then popup mismatch dialog
Click "Cancel" should abort
Click "Flash anyway" should show flashing progress, display "Success" dialog and update to TXBP firmware
Update "backpack" from TXBP to TXBP Should show upload and flashing progress, then display "Success" dialog
Update "TX" firmware using .elrs file Should show upload and flashing progress, then display "Success" dialog

@pkendall64 pkendall64 marked this pull request as draft November 9, 2021 04:16
@pkendall64 pkendall64 force-pushed the wifi-update-fixes branch 2 times, most recently from b201eb3 to 9bf46fb Compare November 10, 2021 02:35
@pkendall64 pkendall64 marked this pull request as ready for review November 10, 2021 06:26
@JyeSmith JyeSmith merged commit 59f95fb into ExpressLRS:master Dec 14, 2021
@pkendall64 pkendall64 deleted the wifi-update-fixes branch December 14, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants