Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toBuffer transparency breaks if not 'auto' #67

Closed
jomo opened this issue Nov 24, 2014 · 3 comments
Closed

toBuffer transparency breaks if not 'auto' #67

jomo opened this issue Nov 24, 2014 · 3 comments
Labels

Comments

@jomo
Copy link
Contributor

jomo commented Nov 24, 2014

img.toBuffer("png", {
  compression: "none",
  transparency: true
}, function(err, buffer) {
  // stuff
});

throws TypeError: Object true has no method 'toLowerCase'

After chaning it to 'true' it throws Error: PNG 'transparency' must be boolean or 'auto'

@EyalAr
Copy link
Owner

EyalAr commented Nov 25, 2014

Confirmed, will fix asap.
Thanks!

@EyalAr EyalAr added the bug label Nov 25, 2014
@EyalAr EyalAr closed this as completed in 84ed584 Nov 25, 2014
@jomo
Copy link
Contributor Author

jomo commented Nov 25, 2014

👍 thanks for making lwip :)

@EyalAr
Copy link
Owner

EyalAr commented Nov 25, 2014

@jomo My pleasure. Thanks for the support.

This bug fixed now. You can check by installing the latest from master with npm install EyalAr/lwip
This fix will land officialy in v0.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants