[fix]: small Compose performance improvements

F0x1d · Jul 12, 2024 · 7ef7939 · 7ef7939
1 parent 034cf37
commit 7ef7939
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/...ore-arch/src/main/kotlin/com/f0x1d/logfox/arch/ui/fragment/compose/BaseComposeFragment.kt b/...ore-arch/src/main/kotlin/com/f0x1d/logfox/arch/ui/fragment/compose/BaseComposeFragment.kt
@@ -4,7 +4,9 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import androidx.compose.foundation.layout.consumeWindowInsets
 import androidx.compose.runtime.Composable
+import androidx.compose.ui.platform.ViewCompositionStrategy
 import com.f0x1d.logfox.arch.databinding.FragmentComposeBinding
 import com.f0x1d.logfox.arch.ui.fragment.BaseFragment
 
@@ -18,8 +20,13 @@ abstract class BaseComposeFragment : BaseFragment<FragmentComposeBinding>() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        binding.composeView.setContent {
-            Content()
+        binding.composeView.apply {
+            consumeWindowInsets = false
+            setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
+
+            setContent {
+                this@BaseComposeFragment.Content()
+            }
         }
     }
 

diff --git a/...src/main/kotlin/com/f0x1d/logfox/arch/ui/fragment/compose/BaseComposeViewModelFragment.kt b/...src/main/kotlin/com/f0x1d/logfox/arch/ui/fragment/compose/BaseComposeViewModelFragment.kt
@@ -6,6 +6,7 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.compose.foundation.layout.consumeWindowInsets
 import androidx.compose.runtime.Composable
+import androidx.compose.ui.platform.ViewCompositionStrategy
 import com.f0x1d.logfox.arch.databinding.FragmentComposeBinding
 import com.f0x1d.logfox.arch.ui.fragment.BaseViewModelFragment
 import com.f0x1d.logfox.arch.ui.snackbar
@@ -25,6 +26,7 @@ abstract class BaseComposeViewModelFragment<T : BaseViewModel> : BaseViewModelFr
 
         binding.composeView.apply {
             consumeWindowInsets = false
+            setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
 
             setContent {
                 this@BaseComposeViewModelFragment.Content()

diff --git a/.../main/kotlin/com/f0x1d/logfox/feature/setup/ui/fragment/setup/compose/SetupScreenState.kt b/.../main/kotlin/com/f0x1d/logfox/feature/setup/ui/fragment/setup/compose/SetupScreenState.kt
@@ -1,10 +1,13 @@
 package com.f0x1d.logfox.feature.setup.ui.fragment.setup.compose
 
+import androidx.compose.runtime.Immutable
+
 data class SetupScreenState(
     val showAdbDialog: Boolean = false,
     val adbCommand: String = "",
 )
 
+@Immutable
 data class SetupScreenListener(
     val onRootClick: () -> Unit,
     val onAdbClick: () -> Unit,