Live player count #197
Merged
Live player count #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norraxx
suggested changes
Sep 19, 2019
| @@ -6,7 +6,7 @@ exports = module.exports = function(req, res) { | |||
| // locals.section is used to set the currently selected | |||
| // item in the header navigation. | |||
| locals.section = 'home'; | |||
|
|
|||
public/js/app/counter.js
Outdated
| console.log($("#game_counter").parent()); | ||
| $.get('lobby_api', { resource: "games"}, function (body) { | ||
| let entries = body; | ||
| if ($("#game_counter").text() == entries.length.toString()) return; |
| request(process.env.LOBBY_API_URL + '/'+req.query.resource, function (error, response, body) { | ||
| res.send(JSON.parse(body)); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Do I understand right, that we're asking our website to ask the api, not the api directly?
Is there any reason to create such unnecessary load?
norraxx
suggested changes
Sep 19, 2019
We don't want caching for this, because we want the player count to be LIVE on the webpage! Also, no database is involved in that query. It's using the python server API. |
|
The "show 0" thing I'm going to remove, as I'm said on zulip i'm not quite done yet. Thats why there is a unused class in sass. For now. |
added 4 commits
September 20, 2019 18:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays live player count and game count on homepage, taken from python server API