-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Makefile #14
Comments
The script could also figure out which version of swig to use ( |
Use the right linker flag for C++ ( |
Differences between Mac and Linux we noticed so far:
|
Currently the NumPy include folder is also hard-coded to the Python 2.7 site-packages directory, which prevented me from installing FALCONN for Python 3 using pip. Other than that it seems to work correctly for Python 3. Using pip I got some seemingly unrelated compiling errors (but I'm far from an expert). After fixing this I was able to install it manually without any further issues. I haven't tried writing some own code yet, but the tests were successful at least. I'm excited by the performance you're able to achieve compared to Annoy. For now I'll stick to Annoy though because of its thread-safety which enables me to do multiple queries in an embarrassingly parallel fashion. |
@wbittremieux what are the compilation errors you were getting? |
@ilyaraz It were some conversion errors in the SWIG wrapper. See this paste for the full output. |
@wbittremieux Thanks! This is very helpful!! |
The build targets for all the tests should be generated fully automatically by a script. The list of headers can also be generated by a script.
The text was updated successfully, but these errors were encountered: