Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBX should be removed from sub index map creation #3100

Closed
jpdean opened this issue Mar 12, 2024 · 2 comments · Fixed by #3392
Closed

NBX should be removed from sub index map creation #3100

jpdean opened this issue Mar 12, 2024 · 2 comments · Fixed by #3392
Assignees
Labels
high-priority task A task to perform
Milestone

Comments

@jpdean
Copy link
Member

jpdean commented Mar 12, 2024

A call to NBX was added in this PR to fix a bug in sub map creation, however, it should be possible to compute the sub map destination ranks without it by adding an extra communication step

@garth-wells
Copy link
Member

@jpdean can this be fixed easily?

@jpdean
Copy link
Member Author

jpdean commented Apr 22, 2024

Getting it to work shouldn't be too tricky, but doing it in a tidy, efficient way will need some thought. The main difficulty is that it's easy to overlook corner cases. I'll have a look at it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority task A task to perform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants