Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve enums SparkCompare.scala #33

Open
aosama opened this issue Sep 26, 2018 · 0 comments
Open

Improve enums SparkCompare.scala #33

aosama opened this issue Sep 26, 2018 · 0 comments
Assignees
@mmlinford

Comments

@aosama
Copy link
Member

aosama commented Sep 26, 2018

Maybe sourceType should have a method like supportsSchemaCompare. That way we have the logic in one place, it won't be messy if we add more source types, and we could avoid the nested ifs with just having if (left.sourceType.supportsSchemaCompare() && right.sourceType.supportsSchemaCompare()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmlinford mmlinford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmlinford @aosama