Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repository schema] Some categoryType's attributes should be required. #191

Open
francescoloconte opened this issue Oct 21, 2023 · 2 comments · Fixed by #234 or FIXTradingCommunity/fix-orchestra-spec#62
Open

[repository schema] Some categoryType's attributes should be required. #191

francescoloconte opened this issue Oct 21, 2023 · 2 comments · Fixed by #234 or FIXTradingCommunity/fix-orchestra-spec#62
Assignees
@francescoloconte
Labels
ERRATA Errors and omissions, inconsistencies

Comments

@francescoloconte
Copy link

The categoryType doesn’t have any required attributes. Seems like the name attribute should be marked as required, and maybe componentType too. For example, in FIX Basic XML format, the name, FIXMLFileName, and componentType are marked as required. The same issue found in sectionType.

image
@kleihan kleihan changed the title Some categoryType's attributes should be required. [repository schema] Some categoryType's attributes should be required. Oct 27, 2023
@francescoloconte
Copy link
Author

It would be useful to get feedback from the community about this change. Lacking that, @kleihan , what's your thoughts about this? If you supported it, I would create a PR for this. It would make the name and componentType attributes mandatory for both the categoryType and sectionType.

@kleihan kleihan added the ERRATA Errors and omissions, inconsistencies label Aug 21, 2024
@martinswanson martinswanson mentioned this issue Sep 10, 2024
Open
@martinswanson
Copy link

Visualisation tools like FIXimate use section and category for message navigation, so I agree it makes sense to make certain fields required.

Proposal

  • Make name and section required attributes for categoryType.
  • Make name a required attribute for sectionType.

I do not think we need to make the componentType attribute a required field, as in practice, I have only ever seen it set to "Message". I'd be interested to know if anyone has a valid use case for using "Field".

Note: I have proposed the removal of the componentType attribute in issue #93.

patricklucas added a commit to patricklucas/fix-orchestra that referenced this issue Sep 11, 2024
@patricklucas
[FIXTradingCommunity#191] Make some category, section attrs required
83395f6
@kleihan kleihan linked a pull request Sep 11, 2024 that will close this issue
[#191] Make some category, section attrs required #234
Merged
@kleihan kleihan mentioned this issue Oct 10, 2024
Merged
@kleihan kleihan linked a pull request Oct 10, 2024 that will close this issue
[schema #191] Update sections and categories with required attributes FIXTradingCommunity/fix-orchestra-spec#62
Merged
kleihan added a commit that referenced this issue Nov 4, 2024
@kleihan
Merge pull request #234 from patricklucas/191_cat_section_required_at…
3ad203b 
…tributes

[#191] Make some category, section attrs required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francescoloconte francescoloconte

Labels
ERRATA Errors and omissions, inconsistencies
Projects
Orchestra v1.1 RC2
Status: In progress
Milestone
No milestone
3 participants
@martinswanson @kleihan @francescoloconte