Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve: Collision handling #356

Open
Robadob opened this issue Jul 13, 2020 · 1 comment
Open

Curve: Collision handling #356

Robadob opened this issue Jul 13, 2020 · 1 comment

Comments

@Robadob
Copy link
Member

Robadob commented Jul 13, 2020

Currently device side curve accesses only confirm that type size matches. This is clearly flawed (most types are 4-byte).

This same flaw is present in unregisterVariableByHash()

Temporary solution, also confirm the unmodulated hash matches. This will be a significant improvement, at the cost of an extra memory read. This is probably worth doing at the same time as #353, or atleast CURVEs component of that change.

The long term solutions to this may only be available via RTC, due to the pre-processing which can be performed.

@Robadob Robadob mentioned this issue Nov 12, 2020
29 tasks
@ptheywood ptheywood added this to the v2.0.0-alpha.N milestone Aug 11, 2021
@Robadob
Copy link
Member Author

Robadob commented Jun 28, 2022

Surprisingly never updated this to state we could perform it using type_decode if we provide a manually defined enum for every supported type.

@ptheywood ptheywood removed this from the v2.0.0-alpha.N milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants