From 2bd802abab8b8e351b97164cdf9bcbfe96f2f918 Mon Sep 17 00:00:00 2001 From: Quentin Young Date: Tue, 9 Jan 2018 15:38:17 -0500 Subject: [PATCH] bgpd: use atomic_* ops on _Atomic variables Signed-off-by: Quentin Young --- bgpd/bgp_fsm.c | 8 ++- bgpd/bgp_packet.c | 21 ++++--- bgpd/bgp_snmp.c | 18 +++--- bgpd/bgp_vty.c | 146 +++++++++++++++++++++------------------------- bgpd/bgpd.h | 16 +++++ 5 files changed, 109 insertions(+), 100 deletions(-) diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c index 9e58e466e1b0..b29536088c9e 100644 --- a/bgpd/bgp_fsm.c +++ b/bgpd/bgp_fsm.c @@ -264,14 +264,16 @@ static struct peer *peer_xfer_conn(struct peer *from_peer) } } + + // Note: peer_xfer_stats() must be called with I/O turned OFF + if (from_peer) + peer_xfer_stats(peer, from_peer); + bgp_reads_on(peer); bgp_writes_on(peer); thread_add_timer_msec(bm->master, bgp_process_packet, peer, 0, &peer->t_process_packet); - if (from_peer) - peer_xfer_stats(peer, from_peer); - return (peer); } diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 4b018aef4d54..eed5fdc65d23 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -595,6 +595,7 @@ static int bgp_write_notify(struct peer *peer) assert(type == BGP_MSG_NOTIFY); /* Type should be notify. */ + atomic_fetch_add_explicit(&peer->notify_out, 1, memory_order_relaxed); peer->notify_out++; /* Double start timer. */ @@ -1682,7 +1683,7 @@ static int bgp_notify_receive(struct peer *peer, bgp_size_t size) } /* peer count update */ - peer->notify_in++; + atomic_fetch_add_explicit(&peer->notify_in, 1, memory_order_relaxed); peer->last_reset = PEER_DOWN_NOTIFY_RECEIVED; @@ -2192,7 +2193,8 @@ int bgp_process_packet(struct thread *thread) */ switch (type) { case BGP_MSG_OPEN: - peer->open_in++; + atomic_fetch_add_explicit(&peer->open_in, 1, + memory_order_relaxed); mprc = bgp_open_receive(peer, size); if (mprc == BGP_Stop) zlog_err( @@ -2200,7 +2202,8 @@ int bgp_process_packet(struct thread *thread) __FUNCTION__, peer->host); break; case BGP_MSG_UPDATE: - peer->update_in++; + atomic_fetch_add_explicit(&peer->update_in, 1, + memory_order_relaxed); peer->readtime = monotime(NULL); mprc = bgp_update_receive(peer, size); if (mprc == BGP_Stop) @@ -2209,7 +2212,8 @@ int bgp_process_packet(struct thread *thread) __FUNCTION__, peer->host); break; case BGP_MSG_NOTIFY: - peer->notify_in++; + atomic_fetch_add_explicit(&peer->notify_in, 1, + memory_order_relaxed); mprc = bgp_notify_receive(peer, size); if (mprc == BGP_Stop) zlog_err( @@ -2218,7 +2222,8 @@ int bgp_process_packet(struct thread *thread) break; case BGP_MSG_KEEPALIVE: peer->readtime = monotime(NULL); - peer->keepalive_in++; + atomic_fetch_add_explicit(&peer->keepalive_in, 1, + memory_order_relaxed); mprc = bgp_keepalive_receive(peer, size); if (mprc == BGP_Stop) zlog_err( @@ -2227,7 +2232,8 @@ int bgp_process_packet(struct thread *thread) break; case BGP_MSG_ROUTE_REFRESH_NEW: case BGP_MSG_ROUTE_REFRESH_OLD: - peer->refresh_in++; + atomic_fetch_add_explicit(&peer->refresh_in, 1, + memory_order_relaxed); mprc = bgp_route_refresh_receive(peer, size); if (mprc == BGP_Stop) zlog_err( @@ -2235,7 +2241,8 @@ int bgp_process_packet(struct thread *thread) __FUNCTION__, peer->host); break; case BGP_MSG_CAPABILITY: - peer->dynamic_cap_in++; + atomic_fetch_add_explicit(&peer->dynamic_cap_in, 1, + memory_order_relaxed); mprc = bgp_capability_receive(peer, size); if (mprc == BGP_Stop) zlog_err( diff --git a/bgpd/bgp_snmp.c b/bgpd/bgp_snmp.c index 484ea7c433b6..8317a252e167 100644 --- a/bgpd/bgp_snmp.c +++ b/bgpd/bgp_snmp.c @@ -512,6 +512,7 @@ static u_char *bgpPeerTable(struct variable *v, oid name[], size_t *length, { static struct in_addr addr; struct peer *peer; + uint32_t ui, uo; if (smux_header_table(v, name, length, exact, var_len, write_method) == MATCH_FAILED) @@ -571,21 +572,20 @@ static u_char *bgpPeerTable(struct variable *v, oid name[], size_t *length, return SNMP_INTEGER(peer->as); break; case BGPPEERINUPDATES: - return SNMP_INTEGER(peer->update_in); + ui = atomic_load_explicit(&peer->update_in, + memory_order_relaxed); + return SNMP_INTEGER(ui); break; case BGPPEEROUTUPDATES: - return SNMP_INTEGER(peer->update_out); + uo = atomic_load_explicit(&peer->update_out, + memory_order_relaxed); + return SNMP_INTEGER(uo); break; case BGPPEERINTOTALMESSAGES: - return SNMP_INTEGER(peer->open_in + peer->update_in - + peer->keepalive_in + peer->notify_in - + peer->refresh_in + peer->dynamic_cap_in); + return SNMP_INTEGER(PEER_TOTAL_RX(peer)); break; case BGPPEEROUTTOTALMESSAGES: - return SNMP_INTEGER(peer->open_out + peer->update_out - + peer->keepalive_out + peer->notify_out - + peer->refresh_out - + peer->dynamic_cap_out); + return SNMP_INTEGER(PEER_TOTAL_TX(peer)); break; case BGPPEERLASTERROR: { static u_char lasterror[2]; diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c index d1d684ccb306..d0d84c991dd8 100644 --- a/bgpd/bgp_vty.c +++ b/bgpd/bgp_vty.c @@ -7053,17 +7053,9 @@ static int bgp_show_summary(struct vty *vty, struct bgp *bgp, int afi, int safi, json_object_int_add(json_peer, "remoteAs", peer->as); json_object_int_add(json_peer, "version", 4); json_object_int_add(json_peer, "msgRcvd", - peer->open_in + peer->update_in - + peer->keepalive_in - + peer->notify_in - + peer->refresh_in - + peer->dynamic_cap_in); + PEER_TOTAL_RX(peer)); json_object_int_add(json_peer, "msgSent", - peer->open_out + peer->update_out - + peer->keepalive_out - + peer->notify_out - + peer->refresh_out - + peer->dynamic_cap_out); + PEER_TOTAL_TX(peer)); json_object_int_add(json_peer, "tableVersion", peer->version[afi][safi]); @@ -7120,42 +7112,9 @@ static int bgp_show_summary(struct vty *vty, struct bgp *bgp, int afi, int safi, " "); vty_out(vty, "4 %10u %7u %7u %8" PRIu64 " %4d %4zd %8s", - peer->as, - atomic_load_explicit(&peer->open_in, - memory_order_relaxed) - + atomic_load_explicit( - &peer->update_in, - memory_order_relaxed) - + atomic_load_explicit( - &peer->keepalive_in, - memory_order_relaxed) - + atomic_load_explicit( - &peer->notify_in, - memory_order_relaxed) - + atomic_load_explicit( - &peer->refresh_in, - memory_order_relaxed) - + atomic_load_explicit( - &peer->dynamic_cap_in, - memory_order_relaxed), - atomic_load_explicit(&peer->open_out, - memory_order_relaxed) - + atomic_load_explicit( - &peer->update_out, - memory_order_relaxed) - + atomic_load_explicit( - &peer->keepalive_out, - memory_order_relaxed) - + atomic_load_explicit( - &peer->notify_out, - memory_order_relaxed) - + atomic_load_explicit( - &peer->refresh_out, - memory_order_relaxed) - + atomic_load_explicit( - &peer->dynamic_cap_out, - memory_order_relaxed), - peer->version[afi][safi], 0, peer->obuf->count, + peer->as, PEER_TOTAL_RX(peer), + PEER_TOTAL_TX(peer), peer->version[afi][safi], + 0, peer->obuf->count, peer_uptime(peer->uptime, timebuf, BGP_UPTIME_LEN, 0, NULL)); @@ -9329,34 +9288,46 @@ static void bgp_show_peer(struct vty *vty, struct peer *p, u_char use_json, json_object_int_add(json_stat, "depthInq", 0); json_object_int_add(json_stat, "depthOutq", (unsigned long)p->obuf->count); - json_object_int_add(json_stat, "opensSent", p->open_out); - json_object_int_add(json_stat, "opensRecv", p->open_in); + json_object_int_add(json_stat, "opensSent", + atomic_load_explicit(&p->open_out, + memory_order_relaxed)); + json_object_int_add(json_stat, "opensRecv", + atomic_load_explicit(&p->open_in, + memory_order_relaxed)); json_object_int_add(json_stat, "notificationsSent", - p->notify_out); + atomic_load_explicit(&p->notify_out, + memory_order_relaxed)); json_object_int_add(json_stat, "notificationsRecv", - p->notify_in); - json_object_int_add(json_stat, "updatesSent", p->update_out); - json_object_int_add(json_stat, "updatesRecv", p->update_in); + atomic_load_explicit(&p->notify_in, + memory_order_relaxed)); + json_object_int_add(json_stat, "updatesSent", + atomic_load_explicit(&p->update_out, + memory_order_relaxed)); + json_object_int_add(json_stat, "updatesRecv", + atomic_load_explicit(&p->update_in, + memory_order_relaxed)); json_object_int_add(json_stat, "keepalivesSent", - p->keepalive_out); + atomic_load_explicit(&p->keepalive_out, + memory_order_relaxed)); json_object_int_add(json_stat, "keepalivesRecv", - p->keepalive_in); + atomic_load_explicit(&p->keepalive_in, + memory_order_relaxed)); json_object_int_add(json_stat, "routeRefreshSent", - p->refresh_out); + atomic_load_explicit(&p->refresh_out, + memory_order_relaxed)); json_object_int_add(json_stat, "routeRefreshRecv", - p->refresh_in); + atomic_load_explicit(&p->refresh_in, + memory_order_relaxed)); json_object_int_add(json_stat, "capabilitySent", - p->dynamic_cap_out); + atomic_load_explicit(&p->dynamic_cap_out, + memory_order_relaxed)); json_object_int_add(json_stat, "capabilityRecv", - p->dynamic_cap_in); + atomic_load_explicit(&p->dynamic_cap_in, + memory_order_relaxed)); json_object_int_add(json_stat, "totalSent", - p->open_out + p->notify_out + p->update_out - + p->keepalive_out + p->refresh_out - + p->dynamic_cap_out); + PEER_TOTAL_TX(p)); json_object_int_add(json_stat, "totalRecv", - p->open_in + p->notify_in + p->update_in - + p->keepalive_in + p->refresh_in - + p->dynamic_cap_in); + PEER_TOTAL_RX(p)); json_object_object_add(json_neigh, "messageStats", json_stat); } else { /* Packet counts. */ @@ -9365,25 +9336,38 @@ static void bgp_show_peer(struct vty *vty, struct peer *p, u_char use_json, vty_out(vty, " Outq depth is %lu\n", (unsigned long)p->obuf->count); vty_out(vty, " Sent Rcvd\n"); - vty_out(vty, " Opens: %10d %10d\n", p->open_out, - p->open_in); - vty_out(vty, " Notifications: %10d %10d\n", p->notify_out, - p->notify_in); - vty_out(vty, " Updates: %10d %10d\n", p->update_out, - p->update_in); - vty_out(vty, " Keepalives: %10d %10d\n", p->keepalive_out, - p->keepalive_in); - vty_out(vty, " Route Refresh: %10d %10d\n", p->refresh_out, - p->refresh_in); + vty_out(vty, " Opens: %10d %10d\n", + atomic_load_explicit(&p->open_out, + memory_order_relaxed), + atomic_load_explicit(&p->open_in, + memory_order_relaxed)); + vty_out(vty, " Notifications: %10d %10d\n", + atomic_load_explicit(&p->notify_out, + memory_order_relaxed), + atomic_load_explicit(&p->notify_in, + memory_order_relaxed)); + vty_out(vty, " Updates: %10d %10d\n", + atomic_load_explicit(&p->update_out, + memory_order_relaxed), + atomic_load_explicit(&p->update_in, + memory_order_relaxed)); + vty_out(vty, " Keepalives: %10d %10d\n", + atomic_load_explicit(&p->keepalive_out, + memory_order_relaxed), + atomic_load_explicit(&p->keepalive_in, + memory_order_relaxed)); + vty_out(vty, " Route Refresh: %10d %10d\n", + atomic_load_explicit(&p->refresh_out, + memory_order_relaxed), + atomic_load_explicit(&p->refresh_in, + memory_order_relaxed)); vty_out(vty, " Capability: %10d %10d\n", - p->dynamic_cap_out, p->dynamic_cap_in); + atomic_load_explicit(&p->dynamic_cap_out, + memory_order_relaxed), + atomic_load_explicit(&p->dynamic_cap_in, + memory_order_relaxed)); vty_out(vty, " Total: %10d %10d\n", - p->open_out + p->notify_out + p->update_out - + p->keepalive_out + p->refresh_out - + p->dynamic_cap_out, - p->open_in + p->notify_in + p->update_in - + p->keepalive_in + p->refresh_in - + p->dynamic_cap_in); + PEER_TOTAL_TX(p), PEER_TOTAL_RX(p)); } if (use_json) { diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h index ce565877275f..df46a6112aba 100644 --- a/bgpd/bgpd.h +++ b/bgpd/bgpd.h @@ -829,6 +829,22 @@ struct peer { /* workqueues */ struct work_queue *clear_node_queue; +#define PEER_TOTAL_RX(peer) \ + atomic_load_explicit(&peer->open_in, memory_order_relaxed) + \ + atomic_load_explicit(&peer->update_in, memory_order_relaxed) + \ + atomic_load_explicit(&peer->notify_in, memory_order_relaxed) + \ + atomic_load_explicit(&peer->refresh_in, memory_order_relaxed) + \ + atomic_load_explicit(&peer->keepalive_in, memory_order_relaxed) + \ + atomic_load_explicit(&peer->dynamic_cap_in, memory_order_relaxed) + +#define PEER_TOTAL_TX(peer) \ + atomic_load_explicit(&peer->open_out, memory_order_relaxed) + \ + atomic_load_explicit(&peer->update_out, memory_order_relaxed) + \ + atomic_load_explicit(&peer->notify_out, memory_order_relaxed) + \ + atomic_load_explicit(&peer->refresh_out, memory_order_relaxed) + \ + atomic_load_explicit(&peer->keepalive_out, memory_order_relaxed) + \ + atomic_load_explicit(&peer->dynamic_cap_out, memory_order_relaxed) + /* Statistics field */ _Atomic uint32_t open_in; /* Open message input count */ _Atomic uint32_t open_out; /* Open message output count */