Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape sed replacement strings #84

Closed
FWDekker opened this issue Nov 29, 2023 · 0 comments · Fixed by #87
Closed

escape sed replacement strings #84

FWDekker opened this issue Nov 29, 2023 · 0 comments · Fixed by #87
Assignees
Labels
bug Something isn't working

Comments

@FWDekker
Copy link
Owner

setting MOMMY_CAREGIVER="a\/b" results in the error sed: -e expression #5, char 20: unterminated `s' command because we do sed -e "s/%%CAREGIVER%%/$caregiver/g", which is unsanitised input into the replacement part of the sed command. therefore, mommy should escape the $caregiver; according to this answer it suffices to escape just a few characters~

@FWDekker FWDekker added the bug Something isn't working label Nov 29, 2023
@FWDekker FWDekker self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant