Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Puppet 3.7 / PE 3.4 x64 compatibility changes #5

Open
Iristyle opened this issue Aug 11, 2014 · 4 comments
Open

Upcoming Puppet 3.7 / PE 3.4 x64 compatibility changes #5

Iristyle opened this issue Aug 11, 2014 · 4 comments

Comments

@Iristyle
Copy link

As part of making Puppet compatible with Windows x64 / Ruby 2, we have had to make a number of changes to our included gems, and have removed sys-admin, windows-pr, win32-api and windows-api. Other gems have been upgraded to versions that require FFI and are compatible with x64.

We don't have builds released yet, but keep an eye on https://groups.google.com/forum/#!forum/puppet-announce

I have identified a small issue with the code in this module that will require some updating to ensure it maintains compatibility with both existing Puppet releases and the upcoming releases. I'm getting in touch with you now, so that you're not caught off guard, and so that your module is ready to go by the time 3.7 ships.

Issues:

  • Defines the SendMessageTimeout API call using Ruby's Win32API class, which won't work on x64 due to incorrect definitions for variables that have a platform specific width (such as HANDLE). These API calls should use FFI definitions, so that they are properly defined on both x86 and x64. Many examples exist in the Puppet codebase now in the lib/puppet/util/windows folder, such as https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/process.rb#L214

We will be making an announcement to the puppet-dev list shortly mentioning some of these upcoming changes.
https://groups.google.com/forum/#!forum/puppet-dev

Let me know if you have any questions.

Thanks!

@logicminds
Copy link

@basti1302 was this module updated to take care of these issues?

@basti1302
Copy link
Collaborator

No, it wasn't. I'm not using puppet anymore, and I'm not maintaining this module actively anymore. If you would like to take care of this, go ahead. I would merge it in a timely fashion and/or add you as a collaborator, if you are interested.

@basti1302
Copy link
Collaborator

Closing as I no longer maintain this (also stated in the README now)

@basti1302 basti1302 reopened this Jul 18, 2018
@basti1302
Copy link
Collaborator

Reopening as there is a new maintainer soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants