Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Bio Page #Bug #43

Closed
mikemimik opened this issue Jul 28, 2013 · 6 comments
Closed

Broken Bio Page #Bug #43

mikemimik opened this issue Jul 28, 2013 · 6 comments

Comments

@mikemimik
Copy link

Hey so by accident I managed to break the bio page for myself. It has to do with the way the pages are rendered with the information you put into the textbox.

Current broken page:
https://docs.google.com/file/d/0B6dAeVdSmX3-R0NBMkp6aVZEekU/

Inspected Elements:
https://docs.google.com/file/d/0B6dAeVdSmX3-N1NjVUdWTVppbVE

As you can see the html code is still there but it's stuck inside the <style> tag I tried to add to mark up the page a little.

I would image that @martindale would simply have to remove my bio from the database and it would reset everything back to normal.

Issue being that anyone can do this and break the bio page.

@martindale
Copy link
Member

I believe this is resolved with the sanitization of profile contents; can you confirm?

@mikemimik
Copy link
Author

Just checked. It is fixed.

https://docs.google.com/file/d/0B6dAeVdSmX3-QU5IdVJFY21nc0E/

@martindale
Copy link
Member

Awesome! Thanks for reporting this. :)

@martindale
Copy link
Member

It seems like the lexer changes I made (see markedjs/marked#215 for more info) also break markdown in profiles... we should probably fix this. :)

@martindale martindale reopened this Aug 2, 2013
@martindale
Copy link
Member

Hey there, can you take another look at this? It's been open a while, but I do suspect there is still an issue.

@mikemimik
Copy link
Author

Markdown works in bio and it's also properly sanitized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants