Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RyoamicLights #797

Closed
Madis0 opened this issue Jan 12, 2024 · 6 comments
Closed

RyoamicLights #797

Madis0 opened this issue Jan 12, 2024 · 6 comments
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added

Comments

@Madis0
Copy link
Member

Madis0 commented Jan 12, 2024

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/ryoamiclights

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/ryoamiclights

Source/other link

https://github.com/ThinkingStudios/RyoamicLights

Mod file size

409.64 + 204.22 = 613.86KB

License

(any other license)

What it does

LambDynamicLights forward-ported, using Architectury build process and ObsidianUI (204KB lib)

Why should it be in the modpack

LambDynamicLights is not yet available in 1.20.6 and its dev explicitly said to be busy right now

Why shouldn't it be in the modpack

  • Potential for drama a la Super Better Grass #718
    • Although Lambda was not necessarily against (Neo)Forge ports, and may not be against Fabric-to-Fabric ports
    • Notably Lambda planned to relicense her mods
  • The original should still be updated relatively soon

Additional details

No response

@Madis0 Madis0 added mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity on hold Mods that are waiting for something before inclusion labels Jan 12, 2024
@tomocrafter
Copy link

It seems original one just updated today to support 1.20.4
https://github.com/LambdAurora/LambDynamicLights/releases/tag/v2.3.4%2B1.20.4

@Madis0
Copy link
Member Author

Madis0 commented Feb 6, 2024

Yup.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
@Madis0 Madis0 added rejected Mods and changes that will not be added parity Mods that add Optifine, Bedrock or Forge parity and removed parity Mods that add Optifine, Bedrock or Forge parity on hold Mods that are waiting for something before inclusion labels Feb 6, 2024
@Madis0 Madis0 reopened this Jun 7, 2024
@Madis0 Madis0 removed the rejected Mods and changes that will not be added label Jun 7, 2024
@n0proxy
Copy link

n0proxy commented Jul 24, 2024

Is this being reconsidered for 1.21?

@mpustovoi
Copy link

It seems that LambDynamicLights will have a 1.21 release soon, so there will be no need for RyoamicLights from then on.
Although, RL could be a temporary replacement for LDL (even though RL contains its own unique dependency), since it's been already supporting versions from 1.20.5 to 1.21.1.
I've been using RL all this time, and I haven't seen any problems.

@Madis0
Copy link
Member Author

Madis0 commented Oct 8, 2024

Rejected due to licensing concerns.

I'm well aware there are at least two updated forks of LDL [including this one], however the original creator of LDL does not seem to like Fabric forks of it [...] [which means it may get taken down at any time].

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@Madis0 Madis0 added the rejected Mods and changes that will not be added label Oct 8, 2024
@mpustovoi
Copy link

Well, then I don't get it why LDL is marked with an MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added
Projects
None yet
Development

No branches or pull requests

4 participants