Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement apiVersion for autoscaling/v2beta2 is autocaling/v2, not autoscaling/v1 #251

Closed
2 tasks done
vroad opened this issue Jan 19, 2022 · 3 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@vroad
Copy link

vroad commented Jan 19, 2022

What happened?

Replacement apiVersion for autoscaling/v2beta2 is autocaling/v2, not autoscaling/v1, according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126

The autoscaling/v2beta2 API version of HorizontalPodAutoscaler will no longer be served in v1.26.

  • Migrate manifests and API clients to use the autoscaling/v2 API version, available since v1.23.
  • All existing persisted objects are accessible via the new API

Isn't autocaling/v1 older than autoscaling/v2beta2? v1 was promoted to GA on k8s v1.2, which was released in March 2016.

https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/CHANGELOG/CHANGELOG-1.2.md#other-notable-improvements
https://github.com/kubernetes/kubernetes/releases/tag/v1.2.0

What did you expect to happen?

Pluto outputs autoscaling/v2 as replacement apiVersion.

How can we reproduce this?

I'm still using older version of EKS cluster, and Pluto doesn't output replacement api versions which are supported only in newer k8s versions, so I just searched for source code on GitHub.

pluto/versions.yaml

Lines 236 to 241 in 77934e6

- version: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
deprecated-in: v1.23.0
removed-in: ""
replacement-api: autoscaling/v1
component: k8s

Previous versions of pluto outputted replacement API version even if you are not using k8s 1.23+, which was wrong. I've found the bug because of that: #212

version

Version:5.3.2 Commit:f8a2af06ad6f092f7545f882fe68fe22fbdeebe0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@vroad vroad added bug Something isn't working triage This bug needs triage labels Jan 19, 2022
@sudermanjr
Copy link
Member

Great catch. Thanks @vroad.

Do you want to make the PR to fix the versions yaml file?

@sudermanjr sudermanjr removed the triage This bug needs triage label Jan 20, 2022
@sudermanjr sudermanjr self-assigned this Jan 21, 2022
@vroad
Copy link
Author

vroad commented Jan 24, 2022

Looks like you already fixed it, thank you.

Another thing I was not sure was that how HorizontalPodAutoscaler List resource is used by pluto. Is it even possible to create k8s resources with kind: HorizontalPodAutoscalerList?

@sudermanjr
Copy link
Member

You know, I'm not actually certain about that. I have seen some objects that refer to a list like that, and in the API it's an endpoint. Never tried applying one specifically myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants