Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add chainsaw tests #438

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

eddycharly
Copy link
Contributor

This PR adds chainsaw e2e tests.

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

@eddycharly
Copy link
Contributor Author

eddycharly commented Dec 12, 2023

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I would be okay with going ahead and removing the existing e2e tests just so we don't flood Circle with tests on the next PR.

name: "Chainsaw End-To-End Kubernetes 1.24"
kind_node_image: "kindest/node:v1.24.7@sha256:577c630ce8e509131eab1aea12c022190978dd2f745aac5eb1fe65c0807eb315"
<<: *chainsaw_configuration
- rok8s/kubernetes_e2e_tests:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop 1.23 and 1.24 and move to 1.25-1.27 instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, maybe in a follow up PR ? This is not related to this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Copy link
Contributor Author

This looks great. I would be okay with going ahead and removing the existing e2e tests just so we don't flood Circle with tests on the next PR.

@sudermanjr done

@sudermanjr
Copy link
Member

LGTM. Thanks!

@sudermanjr sudermanjr enabled auto-merge (squash) December 12, 2023 18:25
@sudermanjr sudermanjr merged commit 474390b into FairwindsOps:master Dec 12, 2023
8 checks passed
@eddycharly eddycharly deleted the chainsaw branch December 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants