Firefox Support - Headers.prototype.getAll method has been removed

[dovy]

The Headers.prototype.getAll method has been removed as per the latest Fetch spec. Instead, the Headers.prototype.get method now returns the all values of a given HTTP header in a comma-separated string instead of just the first value.

https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/

Need to use Headers.get() instead.

[dovy]

Solution:

familysearch-javascript-sdk/src/plumbing.js

Line 317 in 6d7b1b0

return all === true ? response.headers.getAll(header) : response.headers.get(header);

try {
    return all === true ? response.headers.getAll(header) : response.headers.get(header);
} catch(err) { // Firefox shim
    return response.headers.get(header);
}

[stoicflame]

Wait a minute...

Are you saying that Firefox doesn't maintain full backwards compatibility forever? Seriously, getting a little annoyed here. Don't you think they should provide some parameter we can pass to revert to the old FF 51 behavior?

😉 Just teasing, @dovy.

[dovy]

I agree and i think it's totally unacceptable. Remember, they're not the best nowadays. I haven't used them for 3 years. ;)

[dovy]

But this is more of a standard change and FireFox is just being more proactive than others.

[stoicflame]

😃 Yes. Of course.

[justincy]

@dovy I'm curious what your usecase is for using the all parameter of the getHeader() method. The SDK never uses it.

I believe that an easier fix would be to deprecate and ignore the all parameter.

[dovy]

I wasn't using it. It's in the piping and firefox was shooting errors when checking for attaching a source to a person. It checks the header to ensure that it's been given a "created" header, than then move forward. This was failing in firefox and causing my app to just freeze with a JS error.

[justincy]

I was wrong about the all parameter it not being used in the SDK:

familysearch-javascript-sdk/src/classes/base.js

Line 173 in 13a386f

this.addLinks(this.helpers.parseLinkHeaders(response.getHeader('link', true)));

I think we can just update that one internal usage and call it good.