You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generally, I am thinking if we can structure this in a way that will support higher dimensions (e.g. P3D, P4D) in the future? That is affected mostly by the electrode parameter structure. As it currently is implemented, the electrode level contains information about the coating (e.g. thickness, porosity, transport efficiency, etc.) and the active material (e.g. stoichiometry, OCP, etc.) while omitting information about the current collectors. While the current collectors are not important for P2D models, they can be very important in P4D models. Also, enabling the possibility to set the composition of the coating (e.g. X wt% active material, Y wt% carbon black) would be good – even if it is not directly supported by PyBaMM at the moment. That would look something like this (just as a pseudo-code example):
Better expression of electrode composition is important (#41), but I don't think that BPX is really the place for capturing general informational content about a cell, independent from a model. Parameters should be introduced to BPX only when they appear in a supported mathematical model.
+1 for separating material-level information from electrode-level information, especially as this is already what is done by BPX for blended electrodes. Specifically, I wish we had defined PyBaMM to use "active fraction of solid" (between 0 and 1) instead of "active material volume fraction" (between 0 and 1-porosity)
Simon Clark (SINTEF) wrote:
The text was updated successfully, but these errors were encountered: