Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROM file not found on ale_py 0.9.0. Should the docs example be changed? #538

Closed
floringogianu opened this issue Jul 11, 2024 · 4 comments · Fixed by #540
Closed

ROM file not found on ale_py 0.9.0. Should the docs example be changed? #538

floringogianu opened this issue Jul 11, 2024 · 4 comments · Fixed by #540

Comments

@floringogianu
Copy link

Installed ale_py with pip install ale_py in a conda environment. The following snippet crashes with ROM file XXX not found for any game:

from ale_py import ALEInterface

ale = ALEInterface()
ale.loadROM("Pong")

What works instead is importing roms and using the get_rom_path utility:

from ale_py import ALEInterface, roms

ale = ALEInterface()
ale.loadROM(roms.get_rom_path("pong"))
@pseudo-rnd-thoughts
Copy link
Member

Thanks for the issue, @jjshoots is there a nice solution to this where we don't need to change the example?

@jjshoots
Copy link
Member

Interesting... I think during the past update, we moved the location where all the roms were to another place, and an underlying binding didn't get the memo. I think it wouldn't be too hard to fix the C API. I can get to it tomorrow.

@pseudo-rnd-thoughts
Copy link
Member

@jjshoots or @floringogianu Could you make a PR to update the documentation

@jjshoots
Copy link
Member

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants