-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #643: Add ToXmlGenerator.Feature
or allowing XML Schema/JAXB compatible Infinity representation
#644
Fix #643: Add ToXmlGenerator.Feature
or allowing XML Schema/JAXB compatible Infinity representation
#644
Conversation
…ation for floating-point infinity. Fixes FasterXML#643.
src/main/java/com/fasterxml/jackson/dataformat/xml/ser/ToXmlGenerator.java
Show resolved
Hide resolved
*<p> | ||
* Feature is disabled by default for backwards compatibility. | ||
*/ | ||
XML_SCHEMA_CONFORMING_FLOATS(false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good but maybe add WRITE_
prefix to go along with existing WRITE_NULLS_AS_XSI_NIL
?
src/test/java/com/fasterxml/jackson/dataformat/xml/ser/TestSerialization.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; added some minor suggestions to change.
@ahcodedthat Excellent, looks good, I like the implementation. One process thing before I can merge this: if we do not yet have CLA from you (one is enough for all contributions so this is needed just once), we'd need one from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (there's also corporate CLA as an alterative if preferred). It is usually easiest to print, fill & sign, scan/photo, email to Once I have it, can proceed with merge and this should nicely get into 2.17.0 as one of the (if not the :)) last feature to be included. Looking forward to merging this nice addition; thank you again for submitting it! |
Hoping to get CLA resolved by tomorrow as I will need to proceed with 2.17.0 release. |
ToXmlGenerator.Feature
or allowing XML Schema/JAXB compatible Infinity representation
Sorry for the delay! I just sent the filled-out CLA. |
Thank you @ahcodedthat for sending CLA -- I was counting on it getting done soon so it made it in 2.17! :) |
This PR adds a
ToXmlGenerator.Feature
to use XML Schema-compatible representation for floating-point infinity.Fixes #643.