-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soujuurou/Charlotte/Hakunon #1811
base: master
Are you sure you want to change the base?
Conversation
This script is working, we just need to discuss something about the commands to be laid out. |
I was thinking about replacing Emiya with Command Card Change (CCC) and then adding options for the different servants within this option |
This comment has been minimized.
This comment has been minimized.
6d3a4b0
to
e22595b
Compare
updated Soujuurou's command skill
PR is now ready for more testing. |
Might be good idea to start migrating other special commands too Kukulcan
Transform
But let the old code stay here for backwards compatibility, but any new codes would use the new format or probably in a new PR after this get merged. |
Going to rename the function thanks to Charlotte's new skill |
Updated to use
[
and]
to signify the Special command[TCh1]
-> Choice 1 of 3[TCh2]
-> Choice 2 of 3[TCh3]
-> Choice 3 of 3All new Special Target have special condition that one of the commands must not look like the starting string for another code
For Example
[TCh1]
-> Choice 1 of 3There should be no
[TCh]
command, as having so will create problems when parsing. Already added checker on the code that will throw an error when run on device.Updated the error message when manually entering skill command for more clarity
fixes #1841