Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(cd): remove dev values from package.json #1087

Merged
merged 1 commit into from
Nov 28, 2022
Merged

ci(cd): remove dev values from package.json #1087

merged 1 commit into from
Nov 28, 2022

Conversation

Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Oct 25, 2022 •
edited
Loading

Should stop any malicious dev dependencies/scripts from being triggered in production if, when deploying, the user forgets the --ignore-scripts --omit=dev args.

@Fdawgs Fdawgs force-pushed the ci/cd branch 2 times, most recently from 49b708f to dc6e1f6 Compare November 1, 2022 14:06
@coveralls
Copy link

coveralls commented Nov 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3564170856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3564147482: 0.0%
Covered Lines: 607
Relevant Lines: 607
💛 - Coveralls

@Fdawgs Fdawgs self-assigned this Nov 16, 2022
@Fdawgs Fdawgs merged commit b8da792 into master Nov 28, 2022
@Fdawgs Fdawgs deleted the ci/cd branch November 28, 2022 14:42
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fdawgs Fdawgs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @coveralls