fix(index): catch empty file vars before unrtf parses them

Fdawgs · Oct 27, 2020 · 789afbd · 789afbd
1 parent 81af8a4
commit 789afbd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -108,6 +108,11 @@ class UnRTF {
 			printVersionInfo: { arg: '--version', type: 'boolean' }
 		};
 
+		// UnRTF still attempts to convert empty strings/files, so catch them here before
+		if (file === undefined || Object.keys(file).length === 0) {
+			throw new Error('File missing');
+		}
+
 		try {
 			const args = await parseOptions(options, acceptedOptions);
 			args.push(file);

diff --git a/src/index.test.js b/src/index.test.js
@@ -122,4 +122,18 @@ describe('convert function', () => {
 			expect(err.message).toEqual("Invalid option provided 'outputMp3'");
 		});
 	});
+
+	test('Should return an Error object if file is missing', async () => {
+		const unRtf = new UnRTF(testBinaryPath);
+		const options = {
+			noPictures: true,
+			outputHtml: 'sure'
+		};
+
+		await unRtf.convert(undefined, options).catch((err) => {
+			expect(err.message).toEqual(
+				"File missing"
+			);
+		});
+	});
 });