Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix support #1

Closed
Jappie3 opened this issue Jul 21, 2024 · 4 comments
Closed

Nix support #1

Jappie3 opened this issue Jul 21, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Jappie3
Copy link

Jappie3 commented Jul 21, 2024

Hi, first of all: thanks for creating wl-restart! It looks like an amazing tool that I'd love to use on Nix. Would it by ok for you if I created a MR that packages wl-restart using a Nix flake? (this would mean adding the flake.nix & flake.lock files to the repo)

@Ferdi265 Ferdi265 added the enhancement New feature or request label Jul 21, 2024
@Ferdi265
Copy link
Owner

Hi!

Cool to see that you like it!

I'd prefer it if wl-restart is packaged via nixpkgs similar to how wl-mirror and pipectl are packaged, since I don't like putting packaging-/distro-specific files into the repo.

Otherwise I have no issues with this project being packaged.

@Jappie3
Copy link
Author

Jappie3 commented Jul 21, 2024

all right, thanks for the quick reply! maybe it's time for my first contribution to nixpkgs 😆

@Jappie3 Jappie3 closed this as completed Jul 21, 2024
@Ferdi265
Copy link
Owner

Ferdi265 commented Jul 21, 2024

it seems someone else got there before you, a PR in nixpkgs already exists: NixOS/nixpkgs#328635

@Jappie3
Copy link
Author

Jappie3 commented Jul 22, 2024

was quite busy yesterday & hadn't looked at it yet, thanks for letting me know - knowing me I would've missed it and only noticed it at the last moment xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants