Minor perf improvements in BasePathStrategy and RemoteAuthenticationCallbackStrategy #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ToLowerInvariant() to reduce allocations in RemoteAuthenticationCallbackStrategy
|
This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
## [6.11.0](v6.10.0...v6.11.0) (2023-07-01) ### Features * add HasResolvedTenant to IMultiTenantContext ([#650](#650)) ([375add5](375add5)) * perf improvements in BasePathStrategy and RemoteAuthenticationCallbackStrategy ([#654](#654)) ([ac1c58a](ac1c58a)) ### Bug Fixes * internal refactoring and improved XML comments for intellisense ([c42c53d](c42c53d)) * xml docs corrections ([#639](#639)) ([265d26d](265d26d))
|
🎉 This PR is included in version 6.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will reduce (some) allocations in
RemoteAuthenticationCallbackStrategyandBasePathStrategy.RemoteAuthenticationCallbackStrategy
Instead of
ToLowerInvariant() ==comparison, usestring.Equals(a,b,StringComparison.OrdinalIgnoreCase)BasePathStrategy
Stop splitting the path segments after 2 entries have been found, this optimizes for paths with lots of segments.