{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":712769692,"defaultBranch":"main","name":"cometbft","ownerLogin":"Finschia","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-11-01T06:40:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/122864552?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1704252149.0","currentOid":""},"activityList":{"items":[{"before":"d93ba1add2bdea62cf4aeec3e11a998855c1a240","after":"f4a803f14a2f5bc5c17d75fcd1131b9249bba133","ref":"refs/heads/main","pushedAt":"2024-04-24T01:27:49.000Z","pushType":"push","commitsCount":415,"pusher":{"login":"tkxkd0159","name":"Jaeseung Lee","path":"/tkxkd0159","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/41176085?s=80&v=4"},"commit":{"message":"chore(blocksync): improve err message (#2872)\n\nCloses #2871\n\n<!--\n\nPlease add a reference to the issue that this PR addresses and indicate\nwhich\nfiles are most critical to review. If it fully addresses a particular\nissue,\nplease include \"Closes #XXX\" (where \"XXX\" is the issue number).\n\nIf this PR is non-trivial/large/complex, please ensure that you have\neither\ncreated an issue that the team's had a chance to respond to, or had some\ndiscussion with the team prior to submitting substantial pull requests.\nThe team\ncan be reached via GitHub Discussions or the Cosmos Network Discord\nserver in\nthe #cometbft channel. GitHub Discussions is preferred over Discord as\nit\nallows us to keep track of conversations topically.\nhttps://github.com/cometbft/cometbft/discussions\n\nIf the work in this PR is not aligned with the team's current\npriorities, please\nbe advised that it may take some time before it is merged - especially\nif it has\nnot yet been discussed with the team.\n\nSee the project board for the team's current priorities:\nhttps://github.com/orgs/cometbft/projects/1\n\n-->\n\n---\n\n#### PR checklist\n\n- [ ] ~~Tests written/updated~~\n- [ ] ~~Changelog entry added in `.changelog` (we use\n[unclog](https://github.com/informalsystems/unclog) to manage our\nchangelog)~~\n- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code\ncomments~~\n- [x] Title follows the [Conventional\nCommits](https://www.conventionalcommits.org/en/v1.0.0/) spec\n\nCo-authored-by: Andy Nogueira <me@andynogueira.dev>","shortMessageHtmlLink":"chore(blocksync): improve err message (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2258533442\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cometbft/cometbft/issues/2872\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cometbft/cometbft/pull/2872/hovercard\" href=\"https://github.com/cometbft/cometbft/pull/2872\">cometbft#2872</a>)"}},{"before":"721ac3cc19dd5f7f2ce4b851f6ac378435dc520f","after":"2a8c5ffc0e3d81117b34fedb9f9584f1aba8216c","ref":"refs/heads/v0.38.x","pushedAt":"2024-04-24T01:27:37.000Z","pushType":"push","commitsCount":67,"pusher":{"login":"tkxkd0159","name":"Jaeseung Lee","path":"/tkxkd0159","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/41176085?s=80&v=4"},"commit":{"message":"perf(libs/json): Lower heap overhead of JSON encoding (backport #2846) (#2875)\n\n---\r\n\r\nMany RPC methods require JSON marshalled responses. We saw this taking a\r\nnotable amount of heap allocation in query serving full nodes. This PR\r\nremoves some extra heap allocations that were being done. We avoided\r\nusing the more efficient encoder.Encode before, because it added a\r\nnewline. This PR changes the function signature for these private\r\nmethods to be using *bytes.Buffer, and then uses the in-buffer methods\r\n(rather than a second copy). We then just truncate the final byte after\r\neach such call, which does not waste any allocations.\r\n\r\nI added a benchmark for the most complex test case. \r\n\r\nOLD:\r\n```\r\nBenchmarkJsonMarshalStruct-12              78992             15542 ns/op            4487 B/op        191 allocs/op\r\n```\r\nNew:\r\n```\r\nBenchmarkJsonMarshalStruct-12              93346             11132 ns/op            3245 B/op         58 allocs/op\r\n```\r\n\r\nRoughly a 3-4x reduction in the number of allocations, and 20% speedup.\r\n\r\n#### PR checklist\r\n\r\n- [x] Tests written/updated - Existing tests cover this\r\n- [x] Changelog entry added in `.changelog` (we use\r\n[unclog](https://github.com/informalsystems/unclog) to manage our\r\nchangelog)\r\n- [x] Updated relevant documentation (`docs/` or `spec/`) and code\r\ncomments\r\n- [x] Title follows the [Conventional\r\nCommits](https://www.conventionalcommits.org/en/v1.0.0/) spec\r\n<hr>This is an automatic backport of pull request #2846 done by\r\n[Mergify](https://mergify.com).\r\n\r\n---------\r\n\r\nCo-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>\r\nCo-authored-by: Andy Nogueira <me@andynogueira.dev>","shortMessageHtmlLink":"perf(libs/json): Lower heap overhead of JSON encoding (backport <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2250456643\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cometbft/cometbft/issues/2846\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cometbft/cometbft/pull/2846/hovercard\" href=\"https://github.com/cometbft/cometbft/pull/2846\">comet…</a>"}},{"before":null,"after":"721ac3cc19dd5f7f2ce4b851f6ac378435dc520f","ref":"refs/heads/v0.38.x","pushedAt":"2024-01-03T03:22:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"0Tech","name":"Youngtaek Yoon","path":"/0Tech","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7023764?s=80&v=4"},"commit":{"message":"Allow blocksync to not verify all signatures (#1858) (#1870)\n\n* Blocksync can skip sigs\r\n\r\n* bump\r\n\r\n(cherry picked from commit 9446e3135c28a92ac2ea9e5191e4c7da7ced7dbb)\r\n\r\nCo-authored-by: Sergio Mena <sergio@informal.systems>","shortMessageHtmlLink":"Allow blocksync to not verify all signatures (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2048131845\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cometbft/cometbft/issues/1858\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cometbft/cometbft/pull/1858/hovercard\" href=\"https://github.com/cometbft/cometbft/pull/1858\">cometbft#1858</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2049989078\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cometbft/cometbft/issues/1870\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cometbft/cometbft/pull/1870/hovercard\" href=\"https://github.com/cometbft/cometbft/pull/1870\">cometbf…</a>"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0yNFQwMToyNzo0OS4wMDAwMDBazwAAAAQ4onro","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0yNFQwMToyNzo0OS4wMDAwMDBazwAAAAQ4onro","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMS0wM1QwMzoyMjoyOS4wMDAwMDBazwAAAAPWduDC"}},"title":"Activity · Finschia/cometbft"}